Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2450)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java

Issue 1470593003: Update content desciption string for bookmark button in NTP toolbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java
index 95dad06bb3e3c022f6bbf6323484847644025b2d..4774642564835440dcc89c7206ebe7d2c00cc9a8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java
@@ -43,8 +43,12 @@ public class NewTabPageToolbar extends LinearLayout {
protected void onFinishInflate() {
mBookmarksButton = initButton(R.id.bookmarks_button, R.drawable.btn_star);
mRecentTabsButton = initButton(R.id.recent_tabs_button, R.drawable.btn_recents);
- ((TextView) mBookmarksButton.getChildAt(0)).setText(OfflinePageBridge.isEnabled()
- ? R.string.offline_pages_ntp_button_name : R.string.ntp_bookmarks);
+ if (OfflinePageBridge.isEnabled()) {
+ ((TextView) mBookmarksButton.getChildAt(0)).setText(
+ R.string.offline_pages_ntp_button_name);
+ ((TextView) mBookmarksButton.getChildAt(0)).setContentDescription(
+ getResources().getString(R.string.offline_pages_ntp_button_accessibility));
+ }
}
private ViewGroup initButton(int buttonId, int drawableId) {
« no previous file with comments | « no previous file | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698