Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 14705005: Archive unstripped nacl irt for official builds. (Closed)

Created:
7 years, 7 months ago by bradn
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Archive unstripped nacl irt for official builds. Adding archival of unstripped nacl irt binaries. (NOTE: We currently do only strip-debug, so symbol info is actually currently available. Separately we could trim the IRT slightly be dropping this once we are confident in the archiving.) This change dependes on this one landing in nacl and being DEPSed in: https://codereview.chromium.org/14713006/ BUG=None TEST=None R=mark@chromium.org,sbc@chromium.org,igorc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199570

Patch Set 1 #

Patch Set 2 : name change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M chrome/tools/build/linux/FILES.cfg View 1 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/tools/build/mac/FILES.cfg View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
bradn
7 years, 7 months ago (2013-05-01 00:05:50 UTC) #1
Mark Mentovai
LGTM
7 years, 7 months ago (2013-05-01 18:13:36 UTC) #2
bradn
Name change, PTAL Waiting to land until: https://codereview.chromium.org/14713006/ is in and has been rolled into ...
7 years, 7 months ago (2013-05-02 20:08:06 UTC) #3
Mark Mentovai
Still LGTM.
7 years, 7 months ago (2013-05-03 13:15:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/14705005/4001
7 years, 7 months ago (2013-05-06 17:00:49 UTC) #5
bradn
Adding mmoss for OWNERS
7 years, 7 months ago (2013-05-06 17:12:46 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=1581
7 years, 7 months ago (2013-05-06 17:12:49 UTC) #7
mmoss
Does "when available" mean these might not exist? If so, they should be marked as ...
7 years, 7 months ago (2013-05-06 17:17:18 UTC) #8
bradn
That text was a leftover from a prior version. Changed. We're always going to archive ...
7 years, 7 months ago (2013-05-06 19:24:04 UTC) #9
mmoss
lgtm
7 years, 7 months ago (2013-05-06 19:31:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/14705005/4001
7 years, 7 months ago (2013-05-06 19:40:56 UTC) #11
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=1617
7 years, 7 months ago (2013-05-06 19:48:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/14705005/4001
7 years, 7 months ago (2013-05-10 00:25:57 UTC) #13
bradn
Commit queue doesn't seem to want to take it. Will land manually when try opens.
7 years, 7 months ago (2013-05-10 00:30:50 UTC) #14
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=2314
7 years, 7 months ago (2013-05-10 00:36:06 UTC) #15
bradn
Ah, figured it out. LG was from mmoss@google.com mmoss, can I get an lg from ...
7 years, 7 months ago (2013-05-10 17:22:37 UTC) #16
Michael Moss
lgtm
7 years, 7 months ago (2013-05-10 18:09:05 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/14705005/4001
7 years, 7 months ago (2013-05-10 18:16:01 UTC) #18
commit-bot: I haz the power
7 years, 7 months ago (2013-05-10 23:44:26 UTC) #19
Message was sent while issue was closed.
Change committed as 199570

Powered by Google App Engine
This is Rietveld 408576698