Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Side by Side Diff: src/heap/mark-compact.h

Issue 1470253002: [heap] Refactor evacuation for young and old gen into visitors. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment; Added code comments and DCHECK Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/heap/mark-compact.cc » ('j') | src/heap/mark-compact.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_HEAP_MARK_COMPACT_H_ 5 #ifndef V8_HEAP_MARK_COMPACT_H_
6 #define V8_HEAP_MARK_COMPACT_H_ 6 #define V8_HEAP_MARK_COMPACT_H_
7 7
8 #include "src/base/bits.h" 8 #include "src/base/bits.h"
9 #include "src/heap/spaces.h" 9 #include "src/heap/spaces.h"
10 10
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 322
323 323
324 // Defined in isolate.h. 324 // Defined in isolate.h.
325 class ThreadLocalTop; 325 class ThreadLocalTop;
326 326
327 327
328 // ------------------------------------------------------------------------- 328 // -------------------------------------------------------------------------
329 // Mark-Compact collector 329 // Mark-Compact collector
330 class MarkCompactCollector { 330 class MarkCompactCollector {
331 public: 331 public:
332 enum IterationMode {
333 kKeepMarking,
334 kClearMarkbits,
335 };
336
337 class HeapObjectVisitor;
338 class EvacuateNewSpaceVisitor;
339 class EvacuateOldSpaceVisitor;
340
332 static void Initialize(); 341 static void Initialize();
333 342
334 void SetUp(); 343 void SetUp();
335 344
336 void TearDown(); 345 void TearDown();
337 346
338 void CollectEvacuationCandidates(PagedSpace* space); 347 void CollectEvacuationCandidates(PagedSpace* space);
339 348
340 void AddEvacuationCandidate(Page* p); 349 void AddEvacuationCandidate(Page* p);
341 350
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
692 // After: Live objects are unmarked, non-live regions have been added to 701 // After: Live objects are unmarked, non-live regions have been added to
693 // their space's free list. Active eden semispace is compacted by 702 // their space's free list. Active eden semispace is compacted by
694 // evacuation. 703 // evacuation.
695 // 704 //
696 705
697 // If we are not compacting the heap, we simply sweep the spaces except 706 // If we are not compacting the heap, we simply sweep the spaces except
698 // for the large object space, clearing mark bits and adding unmarked 707 // for the large object space, clearing mark bits and adding unmarked
699 // regions to each space's free list. 708 // regions to each space's free list.
700 void SweepSpaces(); 709 void SweepSpaces();
701 710
702 int DiscoverAndEvacuateBlackObjectsOnPage(NewSpace* new_space, 711 // Iterates through all live objects on a page using marking information.
703 NewSpacePage* p); 712 // Returns whether all objects have successfully been visited.
713 bool IterateLiveObjectsOnPage(MemoryChunk* page, HeapObjectVisitor* visitor,
714 IterationMode mode);
704 715
705 void EvacuateNewSpace(); 716 void EvacuateNewSpace();
706 717
707 bool EvacuateLiveObjectsFromPage(Page* p, PagedSpace* target_space,
708 SlotsBuffer** evacuation_slots_buffer);
709
710 void AddEvacuationSlotsBufferSynchronized( 718 void AddEvacuationSlotsBufferSynchronized(
711 SlotsBuffer* evacuation_slots_buffer); 719 SlotsBuffer* evacuation_slots_buffer);
712 720
713 void EvacuatePages(CompactionSpaceCollection* compaction_spaces, 721 void EvacuatePages(CompactionSpaceCollection* compaction_spaces,
714 SlotsBuffer** evacuation_slots_buffer); 722 SlotsBuffer** evacuation_slots_buffer);
715 723
716 void EvacuatePagesInParallel(); 724 void EvacuatePagesInParallel();
717 725
718 // The number of parallel compaction tasks, including the main thread. 726 // The number of parallel compaction tasks, including the main thread.
719 int NumberOfParallelCompactionTasks(); 727 int NumberOfParallelCompactionTasks();
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
857 private: 865 private:
858 MarkCompactCollector* collector_; 866 MarkCompactCollector* collector_;
859 }; 867 };
860 868
861 869
862 const char* AllocationSpaceName(AllocationSpace space); 870 const char* AllocationSpaceName(AllocationSpace space);
863 } // namespace internal 871 } // namespace internal
864 } // namespace v8 872 } // namespace v8
865 873
866 #endif // V8_HEAP_MARK_COMPACT_H_ 874 #endif // V8_HEAP_MARK_COMPACT_H_
OLDNEW
« no previous file with comments | « no previous file | src/heap/mark-compact.cc » ('j') | src/heap/mark-compact.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698