Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 147023002: Notify parent frame renderer when OOP child frame renderer crashes (Closed)

Created:
6 years, 11 months ago by kenrb
Modified:
6 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Notify parent frame renderer when OOP child frame renderer crashes When an out-of-process iframe renderer crashes, this causes the parent renderer to be notified and it will display a solid color instead of the previous rendered texture. This will later be changed to a special 'sad frame' bitmap when OOPIF rendering in Blink is further along. At the time this is being committed the behavior is not observable because of an independent crash bug (338508). Commenting out the following line in RenderViewHostImpl::OnRenderProcessGone() can avert the crash (though it breaks other behavior): delegate_->GetFrameTree()->ResetForMainFrameSwap(); R=jam BUG=325803 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247987

Patch Set 1 : WIP patch #

Patch Set 2 : Iframe displays green rectangle on child frame crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M content/browser/frame_host/cross_process_frame_connector.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/cross_process_frame_connector.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/child_frame_compositing_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/child_frame_compositing_helper.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kenrb
jam: PTAL?
6 years, 10 months ago (2014-01-29 17:41:45 UTC) #1
jam
lgtm
6 years, 10 months ago (2014-01-30 00:01:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenrb@chromium.org/147023002/50001
6 years, 10 months ago (2014-01-30 14:19:31 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=254241
6 years, 10 months ago (2014-01-30 15:47:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenrb@chromium.org/147023002/50001
6 years, 10 months ago (2014-01-30 16:11:43 UTC) #5
commit-bot: I haz the power
Change committed as 247987
6 years, 10 months ago (2014-01-30 17:54:52 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 17:55:00 UTC) #7
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698