content/renderer/child_frame_compositing_helper.cc - Issue 147023002: Notify parent frame renderer when OOP child frame renderer crashes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/child_frame_compositing_helper.cc

Issue 147023002: Notify parent frame renderer when OOP child frame renderer crashes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Iframe displays green rectangle on child frame crash Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/child_frame_compositing_helper.cc

diff --git a/content/renderer/child_frame_compositing_helper.cc b/content/renderer/child_frame_compositing_helper.cc

index f98433af463868b5fbfbcc4b1362b9d6428ea823..433d652175429289ea8c3b928d790aaf3c21f70e 100644

--- a/content/renderer/child_frame_compositing_helper.cc

+++ b/content/renderer/child_frame_compositing_helper.cc

@@ -279,6 +279,13 @@ void ChildFrameCompositingHelper::OnContainerDestroy() {

web_layer_.reset();

}

+void ChildFrameCompositingHelper::ChildFrameGone() {

+ background_layer_->SetBackgroundColor(SkColorSetARGBInline(255, 0, 128, 0));

+ background_layer_->RemoveAllChildren();

+ background_layer_->SetIsDrawable(true);

+ background_layer_->SetContentsOpaque(true);

void ChildFrameCompositingHelper::OnBuffersSwappedPrivate(

const SwapBuffersInfo& mailbox,

unsigned sync_point,