Clarify when oval & rrects get devolved to paths in SkGpuDevice/GrDrawContext boundary

Clarify when oval & rrects get devolved to paths in SkGpuDevice/GrDrawContext boundary

The GrDrawContext drawOval and drawRRect methods are only called from SkGpuDevice so there is no value in delaying the conversion to a path when dashing is involved.

Committed: https://skia.googlesource.com/skia/+/514450cb695279e44af8b30c19e9d866e2eeb818

[robertphillips, 2015-11-23 22:54:00]

Description was changed from

==========
Clarify when oval & rrects get devolved to paths in SkGpuDevice/GrDrawContext
boundary
==========

to

==========
Clarify when oval & rrects get devolved to paths in SkGpuDevice/GrDrawContext
boundary

The GrDrawContext drawOval and drawRRect methods are only called from
SkGpuDevice so there is no value in delaying the conversion to a path when
dashing is involved.
==========

[robertphillips, 2015-11-23 22:54:01]

robertphillips@google.com changed reviewers:
+ egdaniel@chromium.org

[robertphillips, 2015-11-23 22:54:22]

robertphillips@google.com changed reviewers:
+ egdaniel@google.com

[egdaniel, 2015-11-23 23:17:31]

lgtm

[robertphillips, 2015-11-23 23:18:35]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-23 23:18:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470103002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470103002/1

[commit-bot: I haz the power, 2015-11-23 23:19:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 23:19:33]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[robertphillips, 2015-11-24 12:57:57]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-24 12:58:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470103002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470103002/1

[robertphillips, 2015-11-24 13:04:09]

The CQ bit was unchecked by robertphillips@google.com

[robertphillips, 2015-11-24 13:04:14]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-11-24 13:04:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1470103002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1470103002/1

[commit-bot: I haz the power, 2015-11-24 13:36:04]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/514450cb695279e44af8b30c19e9d866e2eeb818

[reed1, 2015-11-24 14:42:29]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2015-11-24 14:42:29]

https://codereview.chromium.org/1470103002/diff/1/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/1470103002/diff/1/src/gpu/SkGpuDevice.cpp#new...
src/gpu/SkGpuDevice.cpp:570: if (paint.getMaskFilter() || paint.getPathEffect())
{
I wonder if a brief comment would help here. Is this because fDrawContext
ignores those two effects? If so, could that be a predicate on fDrawContext?

bool DrawContext::CanApplyToRRect(paint) ?

[robertphillips, 2015-11-24 15:12:01]

Patchset #2 (id:20001) has been deleted