Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Unified Diff: src/gpu/GrDrawContext.cpp

Issue 1470103002: Clarify when oval & rrects get devolved to paths in SkGpuDevice/GrDrawContext boundary (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/SkGpuDevice.cpp » ('j') | src/gpu/SkGpuDevice.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrDrawContext.cpp
diff --git a/src/gpu/GrDrawContext.cpp b/src/gpu/GrDrawContext.cpp
index 1137c57bc474a4f7035f5f607351469d93e0a260..2928025959dce6609ac7c6d6ba68646bfe59c471 100644
--- a/src/gpu/GrDrawContext.cpp
+++ b/src/gpu/GrDrawContext.cpp
@@ -464,13 +464,7 @@ void GrDrawContext::drawRRect(const GrClip& clip,
return;
}
- if (strokeInfo.isDashed()) {
- SkPath path;
- path.setIsVolatile(true);
- path.addRRect(rrect);
- this->drawPath(clip, paint, viewMatrix, path, strokeInfo);
- return;
- }
+ SkASSERT(!strokeInfo.isDashed()); // this should've been devolved to a path in SkGpuDevice
AutoCheckFlush acf(fDrawingManager);
@@ -543,13 +537,7 @@ void GrDrawContext::drawOval(const GrClip& clip,
return;
}
- if (strokeInfo.isDashed()) {
- SkPath path;
- path.setIsVolatile(true);
- path.addOval(oval);
- this->drawPath(clip, paint, viewMatrix, path, strokeInfo);
- return;
- }
+ SkASSERT(!strokeInfo.isDashed()); // this should've been devolved to a path in SkGpuDevice
AutoCheckFlush acf(fDrawingManager);
« no previous file with comments | « no previous file | src/gpu/SkGpuDevice.cpp » ('j') | src/gpu/SkGpuDevice.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698