Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1470093004: Fix clang/win build more after https://codereview.chromium.org/1471123002 (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix clang/win build more after https://codereview.chromium.org/1471123002 Also remove a few Windows newlines :-/ BUG=560836 TBR=jam@chromium.org Committed: https://crrev.com/dcbb834462ebeac05c273eb780ef91b5ea629bc5 Cr-Commit-Position: refs/heads/master@{#361344}

Patch Set 1 #

Patch Set 2 : bleh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M mojo/edk/system/parent_token_serializer_state_win.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/parent_token_serializer_win.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
The windows newlines only show up in "show raw diff". How could these get in ...
5 years ago (2015-11-24 15:17:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470093004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470093004/1
5 years ago (2015-11-24 15:18:10 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/145302)
5 years ago (2015-11-24 15:20:48 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/dcbb834462ebeac05c273eb780ef91b5ea629bc5 Cr-Commit-Position: refs/heads/master@{#361344}
5 years ago (2015-11-24 15:28:04 UTC) #6
Nico
5 years ago (2015-11-24 15:32:44 UTC) #7
Message was sent while issue was closed.
(looks like the cq can't handle patches with windows newline changes)

Powered by Google App Engine
This is Rietveld 408576698