Don't leak the WatcherThreadManager background thread.

Don't leak the WatcherThreadManager background thread.

Leaking it triggered some canary/dev build checks on Windows that ensure we don't leak handles. In this case, the leak is ok, but the simplest thing for now is to stop leaking it. A side-benefit is we ensure that Mojo message loops shut down correctly at process shutdown.

BUG=559238
R=sky@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/a6342a90e9cac7236600ccf63d6ab586d3debfc4

[jam, 2015-11-23 23:13:10]

Description was changed from

==========
Don't leak the WatcherThreadManager background thread.

Leaking it triggered some canary/dev build checks on Windows that ensure we
don't leak handles. In this case, the leak is ok, but the simplest thing for now
is to stop leaking it. A side-benefit is we ensure that Mojo message loops shut
down correctly at process shutdown.

BUG=559238
==========

to

==========
Don't leak the WatcherThreadManager background thread.

Leaking it triggered some canary/dev build checks on Windows that ensure we
don't leak handles. In this case, the leak is ok, but the simplest thing for now
is to stop leaking it. A side-benefit is we ensure that Mojo message loops shut
down correctly at process shutdown.

BUG=559238
==========

[jam, 2015-11-23 23:13:10]

jam@chromium.org changed reviewers:
+ sky@chromium.org

[jam, 2015-11-23 23:25:59]

Patchset #2 (id:20001) has been deleted

[jam, 2015-11-23 23:26:32]

Patchset #2 (id:40001) has been deleted

[sky, 2015-11-24 00:22:25]

LGTM

[jam, 2015-11-24 01:23:09]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2015-11-24 01:27:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471123002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471123002/60001

[commit-bot: I haz the power, 2015-11-24 03:59:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 03:59:57]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jam, 2015-11-24 04:18:59]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2015-11-24 04:20:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471123002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471123002/60001

[commit-bot: I haz the power, 2015-11-24 05:59:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 05:59:13]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2015-11-24 06:34:33]

Patchset 2 (id:??) landed as
https://crrev.com/a6342a90e9cac7236600ccf63d6ab586d3debfc4
Cr-Commit-Position: refs/heads/master@{#361264}

[jam, 2015-11-24 06:35:02]

Committed patchset #2 (id:60001) manually as
a6342a90e9cac7236600ccf63d6ab586d3debfc4 (presubmit successful).