Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1469973002: Initial tests for ReaderModeManager (Closed)

Created:
5 years, 1 month ago by mdjones
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initial tests for ReaderModeManager This adds the mock classes and a initial tests for the ReaderModeManager. BUG= Committed: https://crrev.com/eb605d8b5552a4cb6db686f14513d002f719e367 Cr-Commit-Position: refs/heads/master@{#361226}

Patch Set 1 #

Patch Set 2 : remove todo #

Patch Set 3 : make inner class static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java View 4 chunks +4 lines, -4 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManagerTest.java View 1 2 1 chunk +194 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mdjones
This changes adds the mock classes and only a few tests for the ReaderModeManager; hopefully ...
5 years, 1 month ago (2015-11-23 17:30:31 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 1 month ago (2015-11-23 21:11:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469973002/20001
5 years, 1 month ago (2015-11-23 21:24:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/150248)
5 years, 1 month ago (2015-11-23 22:26:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469973002/40001
5 years, 1 month ago (2015-11-23 23:09:13 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-24 00:23:55 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 00:24:42 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/eb605d8b5552a4cb6db686f14513d002f719e367
Cr-Commit-Position: refs/heads/master@{#361226}

Powered by Google App Engine
This is Rietveld 408576698