Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java

Issue 1469973002: Initial tests for ReaderModeManager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make inner class static Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
index e00460f7d23dc8e50a67e8f5bb12e53d62f3a422..1015bad2e67a1461ad06d20e9c4e4d1848ef3bdf 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
@@ -71,7 +71,7 @@ public class ReaderModeManager extends TabModelSelectorTabObserver
private int mTabId;
// The ReaderModePanel that this class is managing.
- private ReaderModePanel mReaderModePanel;
+ protected ReaderModePanel mReaderModePanel;
// The ChromeActivity that this panel exists in.
private ChromeActivity mChromeActivity;
@@ -289,7 +289,7 @@ public class ReaderModeManager extends TabModelSelectorTabObserver
return tab.getWebContents();
}
- private WebContentsObserver createWebContentsObserver(WebContents webContents) {
+ protected WebContentsObserver createWebContentsObserver(WebContents webContents) {
final int readerTabId = mTabModelSelector.getCurrentTabId();
if (readerTabId == Tab.INVALID_TAB_ID) return null;
@@ -339,7 +339,7 @@ public class ReaderModeManager extends TabModelSelectorTabObserver
* showing.
* @param reason The reason the panel is requesting to be shown.
*/
- private void requestReaderPanelShow(StateChangeReason reason) {
+ protected void requestReaderPanelShow(StateChangeReason reason) {
int currentTabId = mTabModelSelector.getCurrentTabId();
if (currentTabId == Tab.INVALID_TAB_ID) return;
@@ -359,7 +359,7 @@ public class ReaderModeManager extends TabModelSelectorTabObserver
* @param reason The reason the panel is closing.
* @param animate True if the panel should animate closed.
*/
- private void closeReaderPanel(StateChangeReason reason, boolean animate) {
+ protected void closeReaderPanel(StateChangeReason reason, boolean animate) {
if (mReaderModePanel == null) return;
mReaderModePanel.closePanel(reason, animate);
}

Powered by Google App Engine
This is Rietveld 408576698