chrome/browser/ui/views/browser_actions_container_browsertest.cc - Issue 14699002: Move BrowserAction references from ExtensionPrefs to ExtensionActionAPI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/browser_actions_container_browsertest.cc

Issue 14699002: Move BrowserAction references from ExtensionPrefs to ExtensionActionAPI (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_action_context_menu.mm ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/browser_actions_container_browsertest.cc

diff --git a/chrome/browser/ui/views/browser_actions_container_browsertest.cc b/chrome/browser/ui/views/browser_actions_container_browsertest.cc

index 26c49bcd84a6e47e913d263f4f80cd0841fb7d2d..69605f621079fcbecbab9fd88d59f84fd24993e2 100644

--- a/chrome/browser/ui/views/browser_actions_container_browsertest.cc

+++ b/chrome/browser/ui/views/browser_actions_container_browsertest.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/ui/views/browser_actions_container.h"

+#include "chrome/browser/extensions/api/extension_action/extension_action_api.h"

#include "chrome/browser/extensions/browser_action_test_util.h"

#include "chrome/browser/extensions/extension_browsertest.h"

#include "chrome/browser/extensions/extension_service.h"

@@ -178,9 +179,10 @@ IN_PROC_BROWSER_TEST_F(BrowserActionsContainerTest, ForceHide) {

std::string idA = browser_actions_bar()->GetExtensionId(0);

// Force hide this browser action.

- ExtensionService* service = extensions::ExtensionSystem::Get(

- browser()->profile())->extension_service();

- service->extension_prefs()->SetBrowserActionVisibility(

- service->GetExtensionById(idA, false), false);

+ extensions::ExtensionActionAPI::SetBrowserActionVisibility(

+ extensions::ExtensionSystem::Get(browser()->profile())->

+ extension_service()->extension_prefs(),

+ idA,

+ false);

EXPECT_EQ(0, browser_actions_bar()->VisibleBrowserActions());

}