Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 1469813004: Address two minor FIXMEs in Push Messaging layout tests. (Closed)

Created:
5 years, 1 month ago by Peter Beverloo
Modified:
5 years, 1 month ago
Reviewers:
johnme
CC:
chromium-reviews, blink-reviews, Peter Beverloo, johnme+watch_chromium.org, mvanouwerkerk+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Address two minor FIXMEs in Push Messaging layout tests. BUG= Committed: https://crrev.com/af6b1818f357c618791e7a9bb53009276f3f8644 Cr-Commit-Position: refs/heads/master@{#361100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/push_messaging/interfaces.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/push_messaging/resources/interfaces-worker.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
johnme
lgtm
5 years, 1 month ago (2015-11-23 14:08:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469813004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469813004/1
5 years, 1 month ago (2015-11-23 14:08:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 15:06:49 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 15:07:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af6b1818f357c618791e7a9bb53009276f3f8644
Cr-Commit-Position: refs/heads/master@{#361100}

Powered by Google App Engine
This is Rietveld 408576698