Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/push_messaging/interfaces.html

Issue 1469813004: Address two minor FIXMEs in Push Messaging layout tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/push_messaging/resources/interfaces-worker.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/push_messaging/interfaces.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/push_messaging/interfaces.html b/third_party/WebKit/LayoutTests/http/tests/push_messaging/interfaces.html
index fa415a88d7900b5a2d42bcb0ac2e52f1c3e7bfcf..81a242655ffc210e9fa47b77be853373be9528a7 100644
--- a/third_party/WebKit/LayoutTests/http/tests/push_messaging/interfaces.html
+++ b/third_party/WebKit/LayoutTests/http/tests/push_messaging/interfaces.html
@@ -26,9 +26,9 @@
test(function() {
assert_own_property(self, 'PushSubscription', 'PushSubscription needs to be exposed as a global.');
- // FIXME: Assert existence of the attributes when they are properly
- // exposed in the prototype chain. https://crbug.com/43394
+ assert_own_property(PushSubscription.prototype, 'endpoint');
+ assert_own_property(PushSubscription.prototype, 'getKey');
assert_own_property(PushSubscription.prototype, 'unsubscribe');
}, 'PushSubscription should be exposed and have the expected interface in a Document.');
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/push_messaging/resources/interfaces-worker.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698