Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1469803006: NOT FOR REVIEW: Aura Android: Content Shell compiles (Closed)

Created:
5 years ago by mfomitchev
Modified:
4 years, 10 months ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mkwst+moarreviews-shell_chromium.org, tfarina, jam, Peter Beverloo, darin-cc_chromium.org, mikecase+watch_chromium.org, klundberg+watch_chromium.org, jbudorick+watch_chromium.org, jochen+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@auraclank_upstream_wthandroid
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NOT FOR REVIEW: Aura Android: Content Shell compiles This is on top of https://codereview.chromium.org/1455793005/

Patch Set 1 #

Patch Set 2 : Temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+545 lines, -161 lines) Patch
M base/android/java/src/org/chromium/base/CommandLine.java View 1 1 chunk +8 lines, -0 lines 0 comments Download
M base/command_line.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + build/android/adb_run_aura_content_shell View 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/BUILD.gn View 1 2 chunks +11 lines, -1 line 0 comments Download
M content/shell/android/BUILD.gn View 5 chunks +44 lines, -10 lines 0 comments Download
A + content/shell/android/aura_shell_apk/AndroidManifest.xml.jinja2 View 2 chunks +11 lines, -2 lines 0 comments Download
A + content/shell/android/aura_shell_apk/res/values/strings.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/shell/android/aura_shell_apk/src/org/chromium/aura_content_shell_apk/ContentShellActivity.java View 9 chunks +20 lines, -113 lines 0 comments Download
A + content/shell/android/aura_shell_apk/src/org/chromium/aura_content_shell_apk/ContentShellApplication.java View 2 chunks +6 lines, -4 lines 0 comments Download
A content/shell/android/java/src/org/chromium/aura_content_shell/Shell.java View 1 chunk +78 lines, -0 lines 0 comments Download
M content/shell/android/shell_jni_registrar.cc View 2 chunks +7 lines, -1 line 0 comments Download
M content/shell/android/shell_library_loader.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 3 chunks +3 lines, -0 lines 0 comments Download
M content/shell/browser/shell.h View 6 chunks +27 lines, -7 lines 0 comments Download
M content/shell/browser/shell.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_aura.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M content/shell/browser/shell_browser_main_parts.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/browser/shell_views.cc View 1 13 chunks +124 lines, -9 lines 0 comments Download
M ui/aura/window_tree_host.cc View 1 3 chunks +17 lines, -3 lines 0 comments Download
M ui/aura/window_tree_host_platform.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M ui/platform_window/android/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/platform_window/android/java/src/org/chromium/ui/PlatformWindowAndroid.java View 1 3 chunks +4 lines, -0 lines 0 comments Download
A ui/platform_window/android/platform_window_jni_registrar.h View 1 chunk +19 lines, -0 lines 0 comments Download
A ui/platform_window/android/platform_window_jni_registrar.cc View 1 chunk +27 lines, -0 lines 0 comments Download
M ui/views/test/test_views_delegate_aura.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/wm/test/wm_test_helper.h View 1 3 chunks +8 lines, -2 lines 0 comments Download
M ui/wm/test/wm_test_helper.cc View 1 1 chunk +88 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1474873002 Patch 1

Messages

Total messages: 1 (1 generated)
mfomitchev
4 years, 10 months ago (2016-01-27 21:19:46 UTC) #1 
Description was changed from

==========
NOT FOR REVIEW: Aura Android: Content Shell compiles

This is on top of https://codereview.chromium.org/1455793005/
==========

to

==========
NOT FOR REVIEW: Aura Android: Content Shell compiles

This is on top of https://codereview.chromium.org/1455793005/
==========

Powered by Google App Engine
This is Rietveld 408576698