Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1474873002: Android: Don't try to access the native Screen instance when loading resources. (Closed)

Created:
5 years ago by mfomitchev
Modified:
5 years ago
Reviewers:
sadrul, no sievers
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@auraclank_upstream_wthandroid
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Don't try to access the native Screen instance when loading resources. On Aura Android the Screen instance may not be set yet when ResourceBundle::InitSharedInstance is executed. Instead of using the Screen instance to determine the scale factor, just use the available static methods in gfx::Display and gfx::DeviceDisplayInfo. BUG=507792 Committed: https://crrev.com/264cf401157f9b5ef4bad72020a001c1d0bb6d45 Cr-Commit-Position: refs/heads/master@{#363042}

Patch Set 1 #

Patch Set 2 : Trying to get rid of the dependency... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M ui/base/resource/resource_bundle.cc View 2 chunks +8 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
mfomitchev
5 years ago (2015-11-24 22:06:07 UTC) #2
mfomitchev
Note that we are using screen_aura.cc, not screen_android.cc on Android Aura. We wouldn't have this ...
5 years ago (2015-11-24 22:10:06 UTC) #3
no sievers
lgtm
5 years ago (2015-11-24 23:09:39 UTC) #4
sadrul
stamp lgtm
5 years ago (2015-11-25 21:00:34 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 1455793005 Patch 80001). Please resolve the dependency and ...
5 years ago (2015-11-25 22:09:26 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 1455793005 Patch 80001). Please resolve the dependency and ...
5 years ago (2015-12-01 22:09:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1474873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1474873002/20001
5 years ago (2015-12-03 19:05:47 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 20:14:31 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-03 20:15:34 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/264cf401157f9b5ef4bad72020a001c1d0bb6d45
Cr-Commit-Position: refs/heads/master@{#363042}

Powered by Google App Engine
This is Rietveld 408576698