Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1469733006: Revert of Enable compositor-thread property trees (Closed)

Created:
5 years ago by ccameron
Modified:
5 years ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, Ian Vollick, achuith+watch_chromium.org, dzhioev+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, blink-reviews, darin-cc_chromium.org, oshima+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, danakj+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable compositor-thread property trees (patchset #1 id:1 of https://codereview.chromium.org/1449143004/ ) Reason for revert: This is causing overscroll on Mac to fail. Just using the flag --disable-compositor-property-trees fails to make this go away -- I had to do a manual revert BUG=559550 Original issue's description: > Enable compositor-thread property trees > > This enables compositor-thread property trees for all clients of cc. > It also replaces the existing --enable-compositor-property-trees flag > with a --disable-compositor-property-trees flag. > > BUG=481585 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/f626d0b9d0fb2bfde430cf63c5111df7da1fba6f > Cr-Commit-Position: refs/heads/master@{#360635} TBR=enne@chromium.org,jaydasika@chromium.org,piman@chromium.org,ajuma@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=481585 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/8655039d185412d1ab0f13f7c758ea8fc6402384 Cr-Commit-Position: refs/heads/master@{#361246}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -14 lines) Patch
M cc/base/switches.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/base/switches.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M cc/test/data/background_filter_on_scaled_layer_gl.png View Binary file 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 chunks +23 lines, -0 lines 0 comments Download
M ui/compositor/compositor.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ccameron
Created Revert of Enable compositor-thread property trees
5 years ago (2015-11-24 02:55:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469733006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469733006/1
5 years ago (2015-11-24 02:56:45 UTC) #2
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -3 -p1; error: patch ...
5 years ago (2015-11-24 03:00:38 UTC) #4
ccameron
On 2015/11/24 03:00:38, commit-bot: I haz the power wrote: > Failed to apply patch for ...
5 years ago (2015-11-24 03:31:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469733006/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469733006/220001
5 years ago (2015-11-24 03:36:06 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:220001)
5 years ago (2015-11-24 03:39:14 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-24 03:39:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8655039d185412d1ab0f13f7c758ea8fc6402384
Cr-Commit-Position: refs/heads/master@{#361246}

Powered by Google App Engine
This is Rietveld 408576698