Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 1469583002: Remove more superfluous calls to clear frame views during destruction. (Closed)

Created:
5 years, 1 month ago by dcheng
Modified:
5 years ago
Reviewers:
esprehn, Nate Chapin
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove more superfluous calls to clear frame views during destruction. The calls in ~FrameTree aren't needed, since the view is always cleared in detach(). BUG=none Committed: https://crrev.com/8844981696a05f72b6814771a74bec4e410ad71e Cr-Commit-Position: refs/heads/master@{#361472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M third_party/WebKit/Source/core/frame/RemoteFrame.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/FrameTree.cpp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dcheng
Just cleaning up some loose ends.
5 years, 1 month ago (2015-11-21 00:04:35 UTC) #2
dcheng
+japhet, mind taking a look?
5 years ago (2015-11-24 19:22:15 UTC) #4
esprehn
lgtm
5 years ago (2015-11-24 19:33:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469583002/1
5 years ago (2015-11-24 19:46:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 22:23:33 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-24 22:24:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8844981696a05f72b6814771a74bec4e410ad71e
Cr-Commit-Position: refs/heads/master@{#361472}

Powered by Google App Engine
This is Rietveld 408576698