Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: third_party/WebKit/Source/core/page/FrameTree.cpp

Issue 1469583002: Remove more superfluous calls to clear frame views during destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/RemoteFrame.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/page/FrameTree.cpp
diff --git a/third_party/WebKit/Source/core/page/FrameTree.cpp b/third_party/WebKit/Source/core/page/FrameTree.cpp
index 31889059ba15b90bda64f5729ad8858baf4e6564..0a32b5b7eb4da10f88e30dd423dfa7db07d27fdf 100644
--- a/third_party/WebKit/Source/core/page/FrameTree.cpp
+++ b/third_party/WebKit/Source/core/page/FrameTree.cpp
@@ -50,15 +50,6 @@ FrameTree::FrameTree(Frame* thisFrame)
FrameTree::~FrameTree()
{
-#if !ENABLE(OILPAN)
- // FIXME: Why is this here? Doesn't this parallel what we already do in ~LocalFrame?
- for (Frame* child = firstChild(); child; child = child->tree().nextSibling()) {
- if (child->isLocalFrame())
- toLocalFrame(child)->setView(nullptr);
- else if (child->isRemoteFrame())
- toRemoteFrame(child)->setView(nullptr);
- }
-#endif
}
void FrameTree::setName(const AtomicString& name, const AtomicString& fallbackName)
« no previous file with comments | « third_party/WebKit/Source/core/frame/RemoteFrame.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698