Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1469553002: Switch Skia's libjpeg-turbo to 1.4.2 (Closed)

Created:
5 years, 1 month ago by msarett
Modified:
5 years, 1 month ago
Reviewers:
scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Switch Skia's libjpeg-turbo to 1.4.2 The Android security team wants Android to be on the latest version of libjpeg-turbo, so Skia should test on this version as well. This shouldn't affect Gold. I wouldn't be surprised if this causes a few ASAN/valgrind issues that we need to fix. BUG=skia: Committed: https://skia.googlesource.com/skia/+/8e8eda9d4d2e6e65e3339eaaaf8144a4ef6c721c Committed: https://skia.googlesource.com/skia/+/266f24aa9447813e978640e4b21c4dcaa0ec5f69

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -57 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gyp/libjpeg-turbo.gyp View 1 9 chunks +51 lines, -56 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 64 (34 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/1
5 years, 1 month ago (2015-11-20 22:44:30 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/4403) Build-Win-MSVC-x86_64-Debug-Trybot on ...
5 years, 1 month ago (2015-11-20 22:47:11 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/20001
5 years, 1 month ago (2015-11-20 22:49:50 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/4463)
5 years, 1 month ago (2015-11-20 22:54:25 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/40001
5 years, 1 month ago (2015-11-20 23:03:26 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/4464)
5 years, 1 month ago (2015-11-20 23:09:28 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/60001
5 years, 1 month ago (2015-11-20 23:13:25 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/4465)
5 years, 1 month ago (2015-11-20 23:18:05 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/80001
5 years, 1 month ago (2015-11-20 23:26:58 UTC) #22
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/4407) Build-Win-MSVC-x86_64-Debug-Trybot on ...
5 years, 1 month ago (2015-11-20 23:29:57 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/100001
5 years, 1 month ago (2015-11-20 23:51:18 UTC) #26
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/4410)
5 years, 1 month ago (2015-11-20 23:52:09 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/120001
5 years, 1 month ago (2015-11-20 23:54:56 UTC) #30
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 1 month ago (2015-11-20 23:54:57 UTC) #31
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/140001
5 years, 1 month ago (2015-11-21 00:06:44 UTC) #35
msarett
5 years, 1 month ago (2015-11-21 00:08:05 UTC) #38
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/4469)
5 years, 1 month ago (2015-11-21 00:09:25 UTC) #40
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/160001
5 years, 1 month ago (2015-11-21 00:13:44 UTC) #42
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-21 03:34:32 UTC) #45
djsollen
lgtm
5 years, 1 month ago (2015-11-23 13:32:28 UTC) #46
djsollen
-lgtm. Looking at this more closely I think we need to discuss the state of ...
5 years, 1 month ago (2015-11-23 13:36:08 UTC) #47
msarett
Going to go ahead and land this. The longer term plan right now is to ...
5 years, 1 month ago (2015-11-23 14:22:25 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/160001
5 years, 1 month ago (2015-11-23 14:22:53 UTC) #50
commit-bot: I haz the power
Committed patchset #2 (id:160001) as https://skia.googlesource.com/skia/+/8e8eda9d4d2e6e65e3339eaaaf8144a4ef6c721c
5 years, 1 month ago (2015-11-23 14:34:29 UTC) #51
msarett
A revert of this CL (patchset #2 id:160001) has been created in https://codereview.chromium.org/1468073002/ by msarett@google.com. ...
5 years, 1 month ago (2015-11-23 15:25:39 UTC) #52
msarett
This issue was caused because I used the jconfig.h that was autogenerated for my z620. ...
5 years, 1 month ago (2015-11-23 18:41:26 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/180001
5 years, 1 month ago (2015-11-23 18:49:16 UTC) #57
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/4494)
5 years, 1 month ago (2015-11-23 18:51:56 UTC) #59
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/200001
5 years, 1 month ago (2015-11-23 18:55:26 UTC) #63
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 19:09:17 UTC) #64
Message was sent while issue was closed.
Committed patchset #3 (id:200001) as
https://skia.googlesource.com/skia/+/266f24aa9447813e978640e4b21c4dcaa0ec5f69

Powered by Google App Engine
This is Rietveld 408576698