|
|
DescriptionSwitch Skia's libjpeg-turbo to 1.4.2
The Android security team wants Android to be on the latest version
of libjpeg-turbo, so Skia should test on this version as well.
This shouldn't affect Gold.
I wouldn't be surprised if this causes a few ASAN/valgrind issues
that we need to fix.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/8e8eda9d4d2e6e65e3339eaaaf8144a4ef6c721c
Committed: https://skia.googlesource.com/skia/+/266f24aa9447813e978640e4b21c4dcaa0ec5f69
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Messages
Total messages: 64 (34 generated)
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/20001
Description was changed from ========== Switch Skia's libjpeg-turbo to 1.4.2 The Android security team wants Android to be on the latest version of libjpeg-turbo, so Skia should test on this version as well. This shouldn't affect Gold. I wouldn't be concerned if this causes a few ASAN/valgrind issues that we need to fix. BUG=skia: ========== to ========== Switch Skia's libjpeg-turbo to 1.4.2 The Android security team wants Android to be on the latest version of libjpeg-turbo, so Skia should test on this version as well. This shouldn't affect Gold. I wouldn't be surprised if this causes a few ASAN/valgrind issues that we need to fix. BUG=skia: ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
Patchset #3 (id:60001) has been deleted
Patchset #2 (id:40001) has been deleted
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
The CQ bit was checked by msarett@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/120001
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-11-21 05:54 UTC
Patchset #3 (id:100001) has been deleted
Patchset #2 (id:80001) has been deleted
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/140001
Patchset #2 (id:120001) has been deleted
msarett@google.com changed reviewers: + djsollen@google.com, scroggo@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/160001
Patchset #2 (id:140001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
-lgtm. Looking at this more closely I think we need to discuss the state of the git branches before we commit.
Going to go ahead and land this. The longer term plan right now is to set up a copy (with git history) in AOSP and mirror that from Skia. Landing this so we can begin to detect any problems with this copy of turbo.
The CQ bit was checked by msarett@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/160001
Message was sent while issue was closed.
Committed patchset #2 (id:160001) as https://skia.googlesource.com/skia/+/8e8eda9d4d2e6e65e3339eaaaf8144a4ef6c721c
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:160001) has been created in https://codereview.chromium.org/1468073002/ by msarett@google.com. The reason for reverting is: Breaking jpeg decodes everywhere. I need to look into this..
Message was sent while issue was closed.
This issue was caused because I used the jconfig.h that was autogenerated for my z620. SIZEOF_SIZE_T = 8 is not correct on all platforms. I will check in a new jconfig.h and then reland this.
Message was sent while issue was closed.
Description was changed from ========== Switch Skia's libjpeg-turbo to 1.4.2 The Android security team wants Android to be on the latest version of libjpeg-turbo, so Skia should test on this version as well. This shouldn't affect Gold. I wouldn't be surprised if this causes a few ASAN/valgrind issues that we need to fix. BUG=skia: Committed: https://skia.googlesource.com/skia/+/8e8eda9d4d2e6e65e3339eaaaf8144a4ef6c721c ========== to ========== Switch Skia's libjpeg-turbo to 1.4.2 The Android security team wants Android to be on the latest version of libjpeg-turbo, so Skia should test on this version as well. This shouldn't affect Gold. I wouldn't be surprised if this causes a few ASAN/valgrind issues that we need to fix. BUG=skia: Committed: https://skia.googlesource.com/skia/+/8e8eda9d4d2e6e65e3339eaaaf8144a4ef6c721c ==========
The CQ bit was checked by msarett@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com Link to the patchset: https://codereview.chromium.org/1469553002/#ps180001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/180001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
Patchset #3 (id:180001) has been deleted
The CQ bit was checked by msarett@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com Link to the patchset: https://codereview.chromium.org/1469553002/#ps200001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469553002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469553002/200001
Message was sent while issue was closed.
Committed patchset #3 (id:200001) as https://skia.googlesource.com/skia/+/266f24aa9447813e978640e4b21c4dcaa0ec5f69 |