[interpreter] Switch passing of new.target to register.

[interpreter] Switch passing of new.target to register.

This passes the new.target value in a register instead of through a
side-channel via the construct stub. The interpreter entry trampoline
stores this value in a bytecode register so that it can be accessed
directly by the interpreter. The size of the interpreter stack frame
hence grows by one slot.

R=oth@chromium.org
BUG=v8:4544
LOG=n

Committed: https://crrev.com/3d004eeab23c8b47bd9bdd2cc66434dcc19a1b2f
Cr-Commit-Position: refs/heads/master@{#32264}

[Michael Starzinger, 2015-11-24 12:40:40]

mstarzinger@chromium.org changed reviewers:
+ bmeurer@chromium.org, rmcilroy@chromium.org

[Michael Starzinger, 2015-11-24 12:40:41]

mstarzinger@chromium.org changed required reviewers:
+ oth@chromium.org

[Michael Starzinger, 2015-11-24 12:40:41]

Benedikt & Ross: FYI.
Orion: PTAL.

https://codereview.chromium.org/1469313002/diff/1/src/arm64/builtins-arm64.cc
File src/arm64/builtins-arm64.cc (right):

https://codereview.chromium.org/1469313002/diff/1/src/arm64/builtins-arm64.cc...
src/arm64/builtins-arm64.cc:824: __ Push(x3);
Not sure whether this is the best way to construct the frame on RISC
architectures. Happy to change if you think another sequence is better.

[Benedikt Meurer, 2015-11-25 04:51:11]

LGTM from my side.

[oth, 2015-11-25 08:33:43]

looks good here. Ross will be OOO until December 7th.

[Michael Starzinger, 2015-11-25 11:33:52]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-11-25 11:34:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469313002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469313002/1

[commit-bot: I haz the power, 2015-11-25 11:34:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 11:34:03]

All required reviewers (with asterisk prefixes) have not yet approved this CL.

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Michael Starzinger, 2015-11-25 11:35:05]

Description was changed from

==========
[interpreter] Switch passing of new.target to register.

This passes the new.target value in a register instead of through a
side-channel via the construct stub. The interpreter entry trampoline
stores this value in a bytecode register so that it can be accessed
directly by the interpreter. The size of the interpreter stack frame
hence grows by one slot.

R=oth@chromium.org
BUG=v8:4544
LOG=n
==========

to

==========
[interpreter] Switch passing of new.target to register.

This passes the new.target value in a register instead of through a
side-channel via the construct stub. The interpreter entry trampoline
stores this value in a bytecode register so that it can be accessed
directly by the interpreter. The size of the interpreter stack frame
hence grows by one slot.

R=oth@chromium.org
BUG=v8:4544
LOG=n
==========

[Michael Starzinger, 2015-11-25 11:35:05]

mstarzinger@chromium.org changed required reviewers:
- oth@chromium.org

[Michael Starzinger, 2015-11-25 11:35:10]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-11-25 11:35:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1469313002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1469313002/1

[commit-bot: I haz the power, 2015-11-25 11:36:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-25 11:37:33]

Patchset 1 (id:??) landed as
https://crrev.com/3d004eeab23c8b47bd9bdd2cc66434dcc19a1b2f
Cr-Commit-Position: refs/heads/master@{#32264}

[rmcilroy, 2015-12-07 12:05:54]

lgtm, thanks!