Issue 1475643002: [turbofan] Hide dangerous RawMachineAssembler accessors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1475643002: [turbofan] Hide dangerous RawMachineAssembler accessors. (Closed)

Created:
5 years ago by Michael Starzinger

Modified:
5 years ago

Reviewers:
vogelheim

CC:
v8-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-pass-new-target-7

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Hide dangerous RawMachineAssembler accessors. Having access to the unfinished schedule inside of raw machine assembler turned out to be dangerous, because it cannot be used without exporting which in turn computes the RPO of the schedule. R=vogelheim@chromium.org Committed: https://crrev.com/062586dbf9d42726ee692d4daa511773a766ae43 Cr-Commit-Position: refs/heads/master@{#32216}

Patch Set 1 #

Patch Set 2 : Rebased. #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -11 lines)			Patch
M	src/compiler/interpreter-assembler.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/compiler/interpreter-assembler.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/compiler/raw-machine-assembler.h	View	2 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1475643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1475643002/20001

5 years ago (2015-11-24 14:29:45 UTC) #4

commit-bot: I haz the power

5 years ago (2015-11-24 14:51:38 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/062586dbf9d42726ee692d4daa511773a766ae43
Cr-Commit-Position: refs/heads/master@{#32216}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages