Only build PepperVideoSource/DestinationHost when the webrtc is enabled.

Only build PepperVideoSource/DestinationHost when the webrtc is enabled.

R=bbudge@chromium.org, piman@chromium.org, wjia@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199238

[wjia(left Chromium), 2013-05-07 17:25:46]

lgtm

[bbudge, 2013-05-07 17:58:28]

lgtm

[bbudge, 2013-05-07 18:00:55]

https://codereview.chromium.org/14692004/diff/3001/content/renderer/pepper/co...
File content/renderer/pepper/content_renderer_pepper_host_factory.cc (right):

https://codereview.chromium.org/14692004/diff/3001/content/renderer/pepper/co...
content/renderer/pepper/content_renderer_pepper_host_factory.cc:130: #endif
It would be better if the #if only affected the webrtc resources. We will likely
add more private interfaces here in the future. Is there a problem with an empty
switch statement triggering build errors?

[Ronghua Wu (Left Chromium), 2013-05-07 18:03:48]

https://codereview.chromium.org/14692004/diff/3001/content/renderer/pepper/co...
File content/renderer/pepper/content_renderer_pepper_host_factory.cc (right):

https://codereview.chromium.org/14692004/diff/3001/content/renderer/pepper/co...
content/renderer/pepper/content_renderer_pepper_host_factory.cc:130: #endif
On 2013/05/07 18:00:55, bbudge1 wrote:
> It would be better if the #if only affected the webrtc resources. We will
likely
> add more private interfaces here in the future. Is there a problem with an
empty
> switch statement triggering build errors?

What about make that change when we actually have some non-webrtc private
interfaces? It's a bit odd if the switch only has an empty body.

[bbudge, 2013-05-07 18:10:40]

On 2013/05/07 18:03:48, Ronghua Wu wrote:
>
https://codereview.chromium.org/14692004/diff/3001/content/renderer/pepper/co...
> File content/renderer/pepper/content_renderer_pepper_host_factory.cc (right):
> 
>
https://codereview.chromium.org/14692004/diff/3001/content/renderer/pepper/co...
> content/renderer/pepper/content_renderer_pepper_host_factory.cc:130: #endif
> On 2013/05/07 18:00:55, bbudge1 wrote:
> > It would be better if the #if only affected the webrtc resources. We will
> likely
> > add more private interfaces here in the future. Is there a problem with an
> empty
> > switch statement triggering build errors?
> 
> What about make that change when we actually have some non-webrtc private
> interfaces? It's a bit odd if the switch only has an empty body.

sgtm

[Ronghua Wu (Left Chromium), 2013-05-07 22:43:47]

+avi and jam for gyp file approval.

[jam, 2013-05-07 23:29:17]

On 2013/05/07 22:43:47, Ronghua Wu wrote:
> +avi and jam for gyp file approval.

you don't need two owners, removing myself

[Ronghua Wu (Left Chromium), 2013-05-07 23:30:39]

On 2013/05/07 23:29:17, jam wrote:
> On 2013/05/07 22:43:47, Ronghua Wu wrote:
> > +avi and jam for gyp file approval.
> 
> you don't need two owners, removing myself

But I do need either one of you. :)

[Ronghua Wu (Left Chromium), 2013-05-09 17:21:08]

Can any of the content owners help review the gyp change?

[piman, 2013-05-09 17:39:51]

lgtm

[Ronghua Wu (Left Chromium), 2013-05-09 17:42:49]

Committed patchset #1 manually as r199238 (presubmit successful).