Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1469153006: Treat '...' as a non-parent path component outside of Windows. (Closed)

Created:
5 years ago by davidben
Modified:
5 years ago
Reviewers:
Mark Mentovai, jschuh
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Treat '...' as a non-parent path component outside of Windows. https://codereview.chromium.org/12771015 made FilePath::ReferencesParent treat '...' as an illegal path component due to bizarre Windows behaviors, but '...' is a reasonable path component on UNIX. Condition that logic on OS_WIN. BUG=464760 Committed: https://crrev.com/f61e0a571a76b94eb5ce059ea25babff6a2bb3a3 Cr-Commit-Position: refs/heads/master@{#361764}

Patch Set 1 #

Patch Set 2 : Fix sandbox_file_system_backend_delegate_unittest.cc #

Patch Set 3 : DLOG(WARNING) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M base/files/file_path.cc View 1 2 1 chunk +10 lines, -4 lines 0 comments Download
M base/files/file_path_unittest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc View 1 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
davidben
I don't know why anyone would ever make so ridiculous of a filename, but apparently ...
5 years ago (2015-11-24 23:32:11 UTC) #2
jschuh
On 2015/11/24 23:32:11, davidben (slow) wrote: > I don't know why anyone would ever make ...
5 years ago (2015-11-25 18:36:37 UTC) #4
davidben
On 2015/11/25 18:36:37, jschuh (very slow) wrote: > On 2015/11/24 23:32:11, davidben (slow) wrote: > ...
5 years ago (2015-11-25 18:46:06 UTC) #5
jschuh
lgtm
5 years ago (2015-11-25 21:01:24 UTC) #6
davidben
+mark for base OWNERS.
5 years ago (2015-11-25 21:20:10 UTC) #8
Mark Mentovai
LGTM
5 years ago (2015-11-25 22:13:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469153006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469153006/40001
5 years ago (2015-11-25 22:18:55 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-26 00:43:03 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-26 00:43:56 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f61e0a571a76b94eb5ce059ea25babff6a2bb3a3
Cr-Commit-Position: refs/heads/master@{#361764}

Powered by Google App Engine
This is Rietveld 408576698