Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1469123002: [clean-up] Remove allocator dependency from library targets (Closed)

Created:
5 years, 1 month ago by ssid
Modified:
5 years ago
CC:
aboxhall+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@unify_allocator1_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[clean-up] Remove allocator dependency from library targets This CL matches the GYP changes done in crrev.com/1462853002 for gn build files. In gn version, browser_extension, web_cache/browser already do not depend on allocator. chrome_child target already depends on allocator. test_support_gpu does not exist in gn and content_browsertests directly includes those dependencies. All executables that are affected depend on allocator after this patch: browser_tests, chrome, chrome_app_unittests, interactive_ui_tests, performance_browser_tests, sync_integration_tests, sync_performance_tests, unit_tests, chromevox_tests BUG= Committed: https://crrev.com/0a39ba2a53faa0b2ea4370540146f2ec6ce9d09b Cr-Commit-Position: refs/heads/master@{#361382}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (12 generated)
ssid
+jochen, +scottmg +wfh +primiano: I have made matching changes in gn files same as https://codereview.chromium.org/1462853002/. ...
5 years, 1 month ago (2015-11-23 21:05:42 UTC) #4
ssid
+brettw, Since it was your TODO in gn file.
5 years, 1 month ago (2015-11-23 21:49:39 UTC) #6
scottmg
lgtm
5 years, 1 month ago (2015-11-24 00:25:23 UTC) #7
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-11-24 13:05:43 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469123002/1
5 years ago (2015-11-24 14:13:03 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/126913) ios_dbg_simulator_ninja on ...
5 years ago (2015-11-24 14:15:43 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469123002/40001
5 years ago (2015-11-24 14:23:20 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-24 15:23:45 UTC) #16
commit-bot: I haz the power
This CL has an open dependency (Issue 1462853002 Patch 20001). Please resolve the dependency and ...
5 years ago (2015-11-24 17:39:44 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1469123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1469123002/40001
5 years ago (2015-11-24 17:46:36 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years ago (2015-11-24 17:52:34 UTC) #23
commit-bot: I haz the power
5 years ago (2015-11-24 17:53:15 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a39ba2a53faa0b2ea4370540146f2ec6ce9d09b
Cr-Commit-Position: refs/heads/master@{#361382}

Powered by Google App Engine
This is Rietveld 408576698