[clean-up] Remove allocator.gyp dependency from library targets

[clean-up] Remove allocator.gyp dependency from library targets

This CL does a refactoring of the dependencies and do not change any
behavior. The diff between the ninja files is presented in link:
http://pastebin.com/aG6eq5cb.

The test_support_gpu.gypi included allocator.gyp for no reason, and the
only other target that uses this file is content_browsertests, which
already includes allocatpor.gyp with same conditions. So, removing
this dependency here.

target:browser_ui - depends on allocator.gyp in windows
targets that depend on browser_ui:
  chrome_android_core: not used in windows

  Dependency on allocator.gyp exists already for:
  All, browser (explained below)

target:browser - depends on allocator.gyp in windows
targets that depend on browser:
  chrome_android_core: only android
  chromevox_tests: added dependency to allocator.gyp for windows

  Dependency on allocator.gyp exists already for:
    All, interactive_ui_tests, browser_tests, performance_browser_tests
    chrome_main_dll, chrome_initial, unit_tests, chrome_app_unittests

    test_support_sync_integration's executables:
      sync_integration_tests, browser_tests, sync_performance_tests

    test_support_common's executables:
      interactive_ui_tests, browser_tests, performance_browser_tests

    test_support_unit's executables:
      unit_tests

target:renderer - depends and exports dependency on allocator.gyp in
windows
targets that depend on renderer:
  chrome_android_core: not used in windows
  chromevox_tests: added dependency to allocator.gyp for windows
    chrome_child_dll - added dependency.

  Dependency on allocator.gyp exists already for:
    interactive_ui_tests, browser_tests, performance_browser_tests
    sync_integration_tests, chrome_main_dll, chrome_initial, unit_tests
    chrome_app_unittests

    test_support_common - explained earlier.

target:browser_extensions - depends on allocator.gyp in windows
targets that depend on browser_extensions:
  apps - browser (explained above)
  browser_ui (explained above)
  browser_chromeos
    browser (explained above)
    browser_tests
    apps - browser (explained above)

target:web_cache_browser - depends on allocator.gyp in windows
All the targets that depend on web_cache_browser already have
dependency on allocator.gyp:
  browser*, components_unittests

  extensions_browser
    extensions_unittests, browser_extensions*, apps*

    media_router
      browser_ui*, browser*, native_app_window - browser_ui*
      javascript_dialog_extensions_client - browser_ui*
      media_router_test_support
        browser_tests, test_support_unit*, unit_tests

    app_shell_lib
      extensions_browsertests, app_shell, app_shell_unittests

    extensions_test_support
      extensions_unittests, extensions_browsertests, app_shell_unittests
      test_support_common*

* - see previous sections for why it is fine for the target to not
depend on allocator.gyp

BUG=

Committed: https://crrev.com/fccd31cc513c66944a01955638a67d23bdcc0b88
Cr-Commit-Position: refs/heads/master@{#361381}

[ssid, 2015-11-19 11:40:59]

Description was changed from

==========
[clean-up] Remove allocator.gyp dependency from library targets

The test_support_gpu.gypi included allocator.gyp for no reason, and the
only other target that uses this file is content_browsertests, which
already includes allocatpor.gyp with same conditions. So, removing
this dependency here.

[clean-up] Remove allocator.gyp dependency from library targets

target:web_cache_browser - depends on allocator.gyp in windows
All the targets that depend on web_cache_browser already have
dependency on allocator.gyp:
  browser*, components_unittests

  extensions_browser
    extensions_unittests, browser_extensions*, apps*

    media_router
      browser_ui*, browser*, native_app_window - browser_ui*
      javascript_dialog_extensions_client - browser_ui*
      media_router_test_support
        browser_tests, test_support_unit*, unit_tests

    app_shell_lib
      extensions_browsertests, app_shell, app_shell_unittests

    extensions_test_support
      extensions_unittests, extensions_browsertests, app_shell_unittests
      test_support_common*

* - see crrev.com/1459693002 for why it is fine for the target to not
depend on allocator.gyp

[clean-up] Remove allocator.gyp dependency from library targets

target:browser_ui - depends on allocator.gyp in windows
targets that depend on browser_ui:
  chrome_android_core: not used in windows

  Dependency on allocator.gyp exists already for:
  All, browser (explained below)

target:browser - depends on allocator.gyp in windows
targets that depend on browser:
  chrome_android_core: only android
  chromevox_tests: added dependency to allocator.gyp for windows

  Dependency on allocator.gyp exists already for:
    All, interactive_ui_tests, browser_tests, performance_browser_tests
    chrome_main_dll, chrome_initial, unit_tests, chrome_app_unittests

    test_support_sync_integration's executables:
      sync_integration_tests, browser_tests, sync_performance_tests

    test_support_common's executables:
      interactive_ui_tests, browser_tests, performance_browser_tests

    test_support_unit's executables:
      unit_tests

target:renderer - depends and exports dependency on allocator.gyp in
windows
targets that depend on renderer:
  chrome_android_core: not used in windows
  chromevox_tests: added dependency to allocator.gyp for windows

  Dependency on allocator.gyp exists already for:
    interactive_ui_tests, browser_tests, performance_browser_tests
    sync_integration_tests, chrome_main_dll, chrome_initial, unit_tests
    chrome_app_unittests

    chrome_child_dll - chrome_dll, which depends on chrome_main_dll.
    test_support_common - explained earlier.

target:browser_extensions - depends on allocator.gyp in windows
targets that depend on browser_extensions:
  apps - browser (explained above)
  browser_ui (explained above)
  browser_chromeos
    browser (explained above)
    browser_tests
    apps - browser (explained above)

BUG=
==========

to

==========
[clean-up] Remove allocator.gyp dependency from library targets

The test_support_gpu.gypi included allocator.gyp for no reason, and the
only other target that uses this file is content_browsertests, which
already includes allocatpor.gyp with same conditions. So, removing
this dependency here.

target:browser_ui - depends on allocator.gyp in windows
targets that depend on browser_ui:
  chrome_android_core: not used in windows

  Dependency on allocator.gyp exists already for:
  All, browser (explained below)

target:browser - depends on allocator.gyp in windows
targets that depend on browser:
  chrome_android_core: only android
  chromevox_tests: added dependency to allocator.gyp for windows

  Dependency on allocator.gyp exists already for:
    All, interactive_ui_tests, browser_tests, performance_browser_tests
    chrome_main_dll, chrome_initial, unit_tests, chrome_app_unittests

    test_support_sync_integration's executables:
      sync_integration_tests, browser_tests, sync_performance_tests

    test_support_common's executables:
      interactive_ui_tests, browser_tests, performance_browser_tests

    test_support_unit's executables:
      unit_tests

target:renderer - depends and exports dependency on allocator.gyp in
windows
targets that depend on renderer:
  chrome_android_core: not used in windows
  chromevox_tests: added dependency to allocator.gyp for windows
    chrome_child_dll - added dependency.

  Dependency on allocator.gyp exists already for:
    interactive_ui_tests, browser_tests, performance_browser_tests
    sync_integration_tests, chrome_main_dll, chrome_initial, unit_tests
    chrome_app_unittests

    test_support_common - explained earlier.

target:browser_extensions - depends on allocator.gyp in windows
targets that depend on browser_extensions:
  apps - browser (explained above)
  browser_ui (explained above)
  browser_chromeos
    browser (explained above)
    browser_tests
    apps - browser (explained above)


target:web_cache_browser - depends on allocator.gyp in windows
All the targets that depend on web_cache_browser already have
dependency on allocator.gyp:
  browser*, components_unittests

  extensions_browser
    extensions_unittests, browser_extensions*, apps*

    media_router
      browser_ui*, browser*, native_app_window - browser_ui*
      javascript_dialog_extensions_client - browser_ui*
      media_router_test_support
        browser_tests, test_support_unit*, unit_tests

    app_shell_lib
      extensions_browsertests, app_shell, app_shell_unittests

    extensions_test_support
      extensions_unittests, extensions_browsertests, app_shell_unittests
      test_support_common*

* - see previous sections for why it is fine for the target to not
depend on allocator.gyp

BUG=
==========

[ssid, 2015-11-19 11:42:13]

ssid@chromium.org changed reviewers:
+ primiano@chromium.org

[ssid, 2015-11-19 11:42:14]

PTAL, thanks.

[Primiano Tucci (use gerrit), 2015-11-19 13:01:31]

primiano@chromium.org changed reviewers:
+ shess@chromium.org, wfh@chromium.org

[Primiano Tucci (use gerrit), 2015-11-19 13:01:32]

Thanks for the cleanup. LGTM from my side, but mine counts very little here.

Starting pulling in some Win folks.
I doublechecked and I am fairly confident that this CL should have no side
effects.
I diffed the ninja files (without and with this CL) for a
component=static_library build and I see no diff (% small order reshuffling).

See the word-diff of the ninja files here: 
http://pastebin.com/aG6eq5cb

Also, all trybots look green

[Primiano Tucci (use gerrit), 2015-11-19 13:08:14]

Ah, I guess this CL needs a bit more of context:
we plan to do some changes to unify she shim layer on win and Linux in the near
future. The ultimate goal is https://goo.gl/3wKMQH, but that's many steps away.
I will share soon a doc and start a discussion on the shim layer topic, before
submitting any CL for review which makes any behavioral change.

However, while analyzing the situation we realized that there is some cleanup
needed to bring the current state of allocator.gyp to a civilized state.
So the plan here is:
first do some non-functional refactoring which brings gyp files in a sane state
which allows reasoning. This CL is a first step in this direction.
Once the non-functional refactoring is done, I'll share a doc and start a
broader discussion about the proposed shim layer changes.

ssid: can you add a line in the CL description and clarify that this CL is a
pure gyp refactoring and is intended to have no side-effects (you can point to
pastebin.com/aG6eq5cb as a proof)

[ssid, 2015-11-19 13:25:48]

Description was changed from

==========
[clean-up] Remove allocator.gyp dependency from library targets

The test_support_gpu.gypi included allocator.gyp for no reason, and the
only other target that uses this file is content_browsertests, which
already includes allocatpor.gyp with same conditions. So, removing
this dependency here.

target:browser_ui - depends on allocator.gyp in windows
targets that depend on browser_ui:
  chrome_android_core: not used in windows

  Dependency on allocator.gyp exists already for:
  All, browser (explained below)

target:browser - depends on allocator.gyp in windows
targets that depend on browser:
  chrome_android_core: only android
  chromevox_tests: added dependency to allocator.gyp for windows

  Dependency on allocator.gyp exists already for:
    All, interactive_ui_tests, browser_tests, performance_browser_tests
    chrome_main_dll, chrome_initial, unit_tests, chrome_app_unittests

    test_support_sync_integration's executables:
      sync_integration_tests, browser_tests, sync_performance_tests

    test_support_common's executables:
      interactive_ui_tests, browser_tests, performance_browser_tests

    test_support_unit's executables:
      unit_tests

target:renderer - depends and exports dependency on allocator.gyp in
windows
targets that depend on renderer:
  chrome_android_core: not used in windows
  chromevox_tests: added dependency to allocator.gyp for windows
    chrome_child_dll - added dependency.

  Dependency on allocator.gyp exists already for:
    interactive_ui_tests, browser_tests, performance_browser_tests
    sync_integration_tests, chrome_main_dll, chrome_initial, unit_tests
    chrome_app_unittests

    test_support_common - explained earlier.

target:browser_extensions - depends on allocator.gyp in windows
targets that depend on browser_extensions:
  apps - browser (explained above)
  browser_ui (explained above)
  browser_chromeos
    browser (explained above)
    browser_tests
    apps - browser (explained above)


target:web_cache_browser - depends on allocator.gyp in windows
All the targets that depend on web_cache_browser already have
dependency on allocator.gyp:
  browser*, components_unittests

  extensions_browser
    extensions_unittests, browser_extensions*, apps*

    media_router
      browser_ui*, browser*, native_app_window - browser_ui*
      javascript_dialog_extensions_client - browser_ui*
      media_router_test_support
        browser_tests, test_support_unit*, unit_tests

    app_shell_lib
      extensions_browsertests, app_shell, app_shell_unittests

    extensions_test_support
      extensions_unittests, extensions_browsertests, app_shell_unittests
      test_support_common*

* - see previous sections for why it is fine for the target to not
depend on allocator.gyp

BUG=
==========

to

==========
[clean-up] Remove allocator.gyp dependency from library targets

This CL does a refactoring of the dependencies and do not change any
behavior. The diff between the ninja rsp files is presented in link:
http://pastebin.com/aG6eq5cb.

The test_support_gpu.gypi included allocator.gyp for no reason, and the
only other target that uses this file is content_browsertests, which
already includes allocatpor.gyp with same conditions. So, removing
this dependency here.

target:browser_ui - depends on allocator.gyp in windows
targets that depend on browser_ui:
  chrome_android_core: not used in windows

  Dependency on allocator.gyp exists already for:
  All, browser (explained below)

target:browser - depends on allocator.gyp in windows
targets that depend on browser:
  chrome_android_core: only android
  chromevox_tests: added dependency to allocator.gyp for windows

  Dependency on allocator.gyp exists already for:
    All, interactive_ui_tests, browser_tests, performance_browser_tests
    chrome_main_dll, chrome_initial, unit_tests, chrome_app_unittests

    test_support_sync_integration's executables:
      sync_integration_tests, browser_tests, sync_performance_tests

    test_support_common's executables:
      interactive_ui_tests, browser_tests, performance_browser_tests

    test_support_unit's executables:
      unit_tests

target:renderer - depends and exports dependency on allocator.gyp in
windows
targets that depend on renderer:
  chrome_android_core: not used in windows
  chromevox_tests: added dependency to allocator.gyp for windows
    chrome_child_dll - added dependency.

  Dependency on allocator.gyp exists already for:
    interactive_ui_tests, browser_tests, performance_browser_tests
    sync_integration_tests, chrome_main_dll, chrome_initial, unit_tests
    chrome_app_unittests

    test_support_common - explained earlier.

target:browser_extensions - depends on allocator.gyp in windows
targets that depend on browser_extensions:
  apps - browser (explained above)
  browser_ui (explained above)
  browser_chromeos
    browser (explained above)
    browser_tests
    apps - browser (explained above)


target:web_cache_browser - depends on allocator.gyp in windows
All the targets that depend on web_cache_browser already have
dependency on allocator.gyp:
  browser*, components_unittests

  extensions_browser
    extensions_unittests, browser_extensions*, apps*

    media_router
      browser_ui*, browser*, native_app_window - browser_ui*
      javascript_dialog_extensions_client - browser_ui*
      media_router_test_support
        browser_tests, test_support_unit*, unit_tests

    app_shell_lib
      extensions_browsertests, app_shell, app_shell_unittests

    extensions_test_support
      extensions_unittests, extensions_browsertests, app_shell_unittests
      test_support_common*

* - see previous sections for why it is fine for the target to not
depend on allocator.gyp

BUG=
==========

[Primiano Tucci (use gerrit), 2015-11-19 15:20:44]

Description was changed from

==========
[clean-up] Remove allocator.gyp dependency from library targets

This CL does a refactoring of the dependencies and do not change any
behavior. The diff between the ninja rsp files is presented in link:
http://pastebin.com/aG6eq5cb.

The test_support_gpu.gypi included allocator.gyp for no reason, and the
only other target that uses this file is content_browsertests, which
already includes allocatpor.gyp with same conditions. So, removing
this dependency here.

target:browser_ui - depends on allocator.gyp in windows
targets that depend on browser_ui:
  chrome_android_core: not used in windows

  Dependency on allocator.gyp exists already for:
  All, browser (explained below)

target:browser - depends on allocator.gyp in windows
targets that depend on browser:
  chrome_android_core: only android
  chromevox_tests: added dependency to allocator.gyp for windows

  Dependency on allocator.gyp exists already for:
    All, interactive_ui_tests, browser_tests, performance_browser_tests
    chrome_main_dll, chrome_initial, unit_tests, chrome_app_unittests

    test_support_sync_integration's executables:
      sync_integration_tests, browser_tests, sync_performance_tests

    test_support_common's executables:
      interactive_ui_tests, browser_tests, performance_browser_tests

    test_support_unit's executables:
      unit_tests

target:renderer - depends and exports dependency on allocator.gyp in
windows
targets that depend on renderer:
  chrome_android_core: not used in windows
  chromevox_tests: added dependency to allocator.gyp for windows
    chrome_child_dll - added dependency.

  Dependency on allocator.gyp exists already for:
    interactive_ui_tests, browser_tests, performance_browser_tests
    sync_integration_tests, chrome_main_dll, chrome_initial, unit_tests
    chrome_app_unittests

    test_support_common - explained earlier.

target:browser_extensions - depends on allocator.gyp in windows
targets that depend on browser_extensions:
  apps - browser (explained above)
  browser_ui (explained above)
  browser_chromeos
    browser (explained above)
    browser_tests
    apps - browser (explained above)


target:web_cache_browser - depends on allocator.gyp in windows
All the targets that depend on web_cache_browser already have
dependency on allocator.gyp:
  browser*, components_unittests

  extensions_browser
    extensions_unittests, browser_extensions*, apps*

    media_router
      browser_ui*, browser*, native_app_window - browser_ui*
      javascript_dialog_extensions_client - browser_ui*
      media_router_test_support
        browser_tests, test_support_unit*, unit_tests

    app_shell_lib
      extensions_browsertests, app_shell, app_shell_unittests

    extensions_test_support
      extensions_unittests, extensions_browsertests, app_shell_unittests
      test_support_common*

* - see previous sections for why it is fine for the target to not
depend on allocator.gyp

BUG=
==========

to

==========
[clean-up] Remove allocator.gyp dependency from library targets

This CL does a refactoring of the dependencies and do not change any
behavior. The diff between the ninja files is presented in link:
http://pastebin.com/aG6eq5cb.

The test_support_gpu.gypi included allocator.gyp for no reason, and the
only other target that uses this file is content_browsertests, which
already includes allocatpor.gyp with same conditions. So, removing
this dependency here.

target:browser_ui - depends on allocator.gyp in windows
targets that depend on browser_ui:
  chrome_android_core: not used in windows

  Dependency on allocator.gyp exists already for:
  All, browser (explained below)

target:browser - depends on allocator.gyp in windows
targets that depend on browser:
  chrome_android_core: only android
  chromevox_tests: added dependency to allocator.gyp for windows

  Dependency on allocator.gyp exists already for:
    All, interactive_ui_tests, browser_tests, performance_browser_tests
    chrome_main_dll, chrome_initial, unit_tests, chrome_app_unittests

    test_support_sync_integration's executables:
      sync_integration_tests, browser_tests, sync_performance_tests

    test_support_common's executables:
      interactive_ui_tests, browser_tests, performance_browser_tests

    test_support_unit's executables:
      unit_tests

target:renderer - depends and exports dependency on allocator.gyp in
windows
targets that depend on renderer:
  chrome_android_core: not used in windows
  chromevox_tests: added dependency to allocator.gyp for windows
    chrome_child_dll - added dependency.

  Dependency on allocator.gyp exists already for:
    interactive_ui_tests, browser_tests, performance_browser_tests
    sync_integration_tests, chrome_main_dll, chrome_initial, unit_tests
    chrome_app_unittests

    test_support_common - explained earlier.

target:browser_extensions - depends on allocator.gyp in windows
targets that depend on browser_extensions:
  apps - browser (explained above)
  browser_ui (explained above)
  browser_chromeos
    browser (explained above)
    browser_tests
    apps - browser (explained above)


target:web_cache_browser - depends on allocator.gyp in windows
All the targets that depend on web_cache_browser already have
dependency on allocator.gyp:
  browser*, components_unittests

  extensions_browser
    extensions_unittests, browser_extensions*, apps*

    media_router
      browser_ui*, browser*, native_app_window - browser_ui*
      javascript_dialog_extensions_client - browser_ui*
      media_router_test_support
        browser_tests, test_support_unit*, unit_tests

    app_shell_lib
      extensions_browsertests, app_shell, app_shell_unittests

    extensions_test_support
      extensions_unittests, extensions_browsertests, app_shell_unittests
      test_support_common*

* - see previous sections for why it is fine for the target to not
depend on allocator.gyp

BUG=
==========

[ssid, 2015-11-19 16:51:46]

ssid@chromium.org changed reviewers:
+ scottmg@chromium.org
- shess@chromium.org

[ssid, 2015-11-19 16:51:46]

-shess +scottmg
Please take a look at this change.

[scottmg, 2015-11-19 17:31:59]

Is there anything that needs to be done in .gn files?

[ssid, 2015-11-19 17:47:02]

On 2015/11/19 17:31:59, scottmg wrote:
> Is there anything that needs to be done in .gn files?

This is just clean up of gyp files. The gn targets still seems to depend on
allocator. I will send a follow up patch to remove such dependencies from gn as
well.
There is already a lot of inconsistencies between gn and gyp in terms of
allocator target. In gyp files the targets depend on allocator.gyp after
checking for conditions as win_use_allocator_shim or use_allocator==tcmalloc. As
primiano@ mentioned, the aim of this refactoring is to finally bring in such a
state where all the targets in gyp include allocator unconditionally and only
the executable ones depend on allcoator. We thought the first step should be to
remove unnecessary dependencies before removing the conditions. If you prefer
that I remove the dependencies in gn at the same time, then I will update this
CL with gn also. But, this might cause more build breaks and hard to fix them.
So, I think it is better to do it in parts.

[scottmg, 2015-11-19 19:01:45]

On 2015/11/19 17:47:02, ssid wrote:
> On 2015/11/19 17:31:59, scottmg wrote:
> > Is there anything that needs to be done in .gn files?
> 
> This is just clean up of gyp files. The gn targets still seems to depend on
> allocator. I will send a follow up patch to remove such dependencies from gn
as
> well.
> There is already a lot of inconsistencies between gn and gyp in terms of
> allocator target. In gyp files the targets depend on allocator.gyp after
> checking for conditions as win_use_allocator_shim or use_allocator==tcmalloc.
As
> primiano@ mentioned, the aim of this refactoring is to finally bring in such a
> state where all the targets in gyp include allocator unconditionally and only
> the executable ones depend on allcoator. We thought the first step should be
to
> remove unnecessary dependencies before removing the conditions. If you prefer
> that I remove the dependencies in gn at the same time, then I will update this
> CL with gn also. But, this might cause more build breaks and hard to fix them.
> So, I think it is better to do it in parts.

OK. Please do make them the same though, as it's already quite confusing to muck
through the differences between gyp/GN builds.

This lgtm, but wait for Will too.

[Will Harris, 2015-11-19 19:16:01]

yes this cl lgtm, I think you covered all the executable targets.

re: GN I don't think GN fully supports static builds with allocator shims, does
it? I haven't run a GN build in a while, so might be wrong.

[ssid, 2015-11-19 19:49:52]

ssid@chromium.org changed reviewers:
+ jochen@chromium.org

[ssid, 2015-11-19 19:49:52]

+jochen, PTAL, Thanks.

[ssid, 2015-11-19 19:52:01]

On 2015/11/19 19:16:01, Will Harris wrote:
> yes this cl lgtm, I think you covered all the executable targets.
> 
> re: GN I don't think GN fully supports static builds with allocator shims,
does
> it? I haven't run a GN build in a while, so might be wrong.

I haven't looked into the details yet. But the gn build seems to have a shim
layer and most targets include allocator, in static builds.

[Will Harris, 2015-11-19 20:43:32]

> I haven't looked into the details yet. But the gn build seems to have a shim
> layer and most targets include allocator, in static builds.

if that's the case it would be good to also fix the GN builds at the same time,
to avoid any inconsistency in behavior between the gn and gyp bots.

[Primiano Tucci (use gerrit), 2015-11-19 23:11:12]

Oh, my bad, I mistakenly assumed GN for windows was not there at all.
Agree that if there are matching things in GN they need to be changed in this
CL.
ssid can you take care of GN in this CL...assuming that the situation is
symmetrical?
From what I did see in general, the status of "allocator" target in GN is way
better. Wouldn't be surprised if it's just fine there, but need to check.
You can use the same trick that I used here to check about the noop-behavior
(generate ninja file using gn gen, move the out folder, diff the produced ninja
files)

[jochen (gone - plz use gerrit), 2015-11-20 13:40:06]

lgtm

[ssid, 2015-11-24 14:12:01]

The CQ bit was checked by ssid@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-24 14:12:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1462853002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1462853002/20001

[commit-bot: I haz the power, 2015-11-24 16:27:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 16:27:58]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[ssid, 2015-11-24 17:38:56]

The CQ bit was checked by ssid@chromium.org

[commit-bot: I haz the power, 2015-11-24 17:39:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1462853002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1462853002/20001

[commit-bot: I haz the power, 2015-11-24 17:45:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-24 17:45:56]

Patchset 2 (id:??) landed as
https://crrev.com/fccd31cc513c66944a01955638a67d23bdcc0b88
Cr-Commit-Position: refs/heads/master@{#361381}