Add android.mojo application.

Add android.mojo application.

This application exposes android specific capabilities.

R=ppi@chromium.org
BUG=Fixes https://github.com/domokit/mojo/issues/557, https://github.com/domokit/mojo/issues/502, https://github.com/domokit/mojo/issues/503

Committed: https://chromium.googlesource.com/external/mojo/+/9842dd78a8e2924269b967dff0250f1306d495a8

[qsr, 2015-11-23 15:19:57]

Please, do not review this yet. I will probably change the name and add a few
method.

[qsr, 2015-11-23 16:05:40]

PTAL. This is now ready.

[dynin, 2015-11-23 19:47:41]

dynin@google.com changed reviewers:
+ dynin@google.com

[dynin, 2015-11-23 19:47:41]

https://codereview.chromium.org/1468913003/diff/20001/mojo/services/android/i...
File mojo/services/android/interfaces/activity.mojom (right):

https://codereview.chromium.org/1468913003/diff/20001/mojo/services/android/i...
mojo/services/android/interfaces/activity.mojom:18: struct Intent {
We also need the type field here to resolve
https://github.com/domokit/mojo/issues/557
I know Flutter doesn;t support it, but for the syncslides demo we need to launch
a videoplayer, and they to do it is to set the type to "video/*".
If the type is not specified, then the Chrome browser is launched, which
interrupts the presentation.

[qsr, 2015-11-24 09:10:31]

https://codereview.chromium.org/1468913003/diff/20001/mojo/services/android/i...
File mojo/services/android/interfaces/activity.mojom (right):

https://codereview.chromium.org/1468913003/diff/20001/mojo/services/android/i...
mojo/services/android/interfaces/activity.mojom:18: struct Intent {
On 2015/11/23 19:47:41, dynin wrote:
> We also need the type field here to resolve
> https://github.com/domokit/mojo/issues/557
> I know Flutter doesn;t support it, but for the syncslides demo we need to
launch
> a videoplayer, and they to do it is to set the type to "video/*".
> If the type is not specified, then the Chrome browser is launched, which
> interrupts the presentation.

Done.

[ppi, 2015-11-24 12:17:57]

https://codereview.chromium.org/1468913003/diff/40001/mojo/services/android/i...
File mojo/services/android/interfaces/activity.mojom (right):

https://codereview.chromium.org/1468913003/diff/40001/mojo/services/android/i...
mojo/services/android/interfaces/activity.mojom:4: 
If we want to intentionally keep this as close as possible (the same as?) to
https://github.com/flutter/engine/blob/master/sky/services/activity/activity....
, please say that in a comment.

What it would take to actually share this interface with Flutter? Is this
something we want? If so, should we file a bug to track this?

https://codereview.chromium.org/1468913003/diff/40001/mojo/services/android/i...
mojo/services/android/interfaces/activity.mojom:61: interface PathService {
PathService now has ServiceName in
https://github.com/flutter/engine/blob/master/sky/services/activity/activity....,
we probably want to update.

https://codereview.chromium.org/1468913003/diff/40001/services/android/BUILD.gn
File services/android/BUILD.gn (right):

https://codereview.chromium.org/1468913003/diff/40001/services/android/BUILD....
services/android/BUILD.gn:8: android_library("android") {
why not call the application and the directory "activity", matching what is in
Flutter? I realize this is very Android-specific, but many of the services we
have in services/ are to various degree tied with how Android APIs look like. I
think we might want to stick to the convention of naming services by what they
do not where they run for clarity.

https://codereview.chromium.org/1468913003/diff/40001/services/android/src/or...
File services/android/src/org/chromium/mojo/android/ActivityImpl.java (right):

https://codereview.chromium.org/1468913003/diff/40001/services/android/src/or...
services/android/src/org/chromium/mojo/android/ActivityImpl.java:32: * Android
implementation of VSyncProvider.
Update comment and say that this is a port of
https://github.com/flutter/engine/blob/master/sky/services/activity/src/org/d...
.

[qsr, 2015-11-24 13:05:05]

https://codereview.chromium.org/1468913003/diff/40001/mojo/services/android/i...
File mojo/services/android/interfaces/activity.mojom (right):

https://codereview.chromium.org/1468913003/diff/40001/mojo/services/android/i...
mojo/services/android/interfaces/activity.mojom:4: 
On 2015/11/24 12:17:57, ppi wrote:
> If we want to intentionally keep this as close as possible (the same as?) to
>
https://github.com/flutter/engine/blob/master/sky/services/activity/activity....
> , please say that in a comment.
> 
> What it would take to actually share this interface with Flutter? Is this
> something we want? If so, should we file a bug to track this?

Added a comment about the origin of the file.

https://codereview.chromium.org/1468913003/diff/40001/mojo/services/android/i...
mojo/services/android/interfaces/activity.mojom:61: interface PathService {
On 2015/11/24 12:17:57, ppi wrote:
> PathService now has ServiceName in
>
https://github.com/flutter/engine/blob/master/sky/services/activity/activity....,
> we probably want to update.

Done.

https://codereview.chromium.org/1468913003/diff/40001/services/android/BUILD.gn
File services/android/BUILD.gn (right):

https://codereview.chromium.org/1468913003/diff/40001/services/android/BUILD....
services/android/BUILD.gn:8: android_library("android") {
On 2015/11/24 12:17:57, ppi wrote:
> why not call the application and the directory "activity", matching what is in
> Flutter? I realize this is very Android-specific, but many of the services we
> have in services/ are to various degree tied with how Android APIs look like.
I
> think we might want to stick to the convention of naming services by what they
> do not where they run for clarity.

Add comment about the fact that this application regroups all android specific
services.

https://codereview.chromium.org/1468913003/diff/40001/services/android/src/or...
File services/android/src/org/chromium/mojo/android/ActivityImpl.java (right):

https://codereview.chromium.org/1468913003/diff/40001/services/android/src/or...
services/android/src/org/chromium/mojo/android/ActivityImpl.java:32: * Android
implementation of VSyncProvider.
On 2015/11/24 12:17:57, ppi wrote:
> Update comment and say that this is a port of
>
https://github.com/flutter/engine/blob/master/sky/services/activity/src/org/d...
> .

Done.

[ppi, 2015-11-24 14:06:53]

lgtm

[qsr, 2015-11-24 15:33:25]

Committed patchset #4 (id:60001) manually as
9842dd78a8e2924269b967dff0250f1306d495a8 (presubmit successful).