services/android/BUILD.gn - Issue 1468913003: Add android.mojo application.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/android/BUILD.gn

Issue 1468913003: Add android.mojo application. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Add type to intent. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« mojo/services/android/interfaces/activity.mojom ('K') | « mojo/services/mojo_services.gni ('k') | services/android/src/org/chromium/mojo/android/ActivityImpl.java » ('j') | services/android/src/org/chromium/mojo/android/ActivityImpl.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//build/config/android/config.gni")	5 import("//build/config/android/config.gni")

6 import("//build/config/android/rules.gni")	6 import("//build/config/android/rules.gni")

7	7

8 android_library("input") {	8 android_library("android") {
	ppi 2015/11/24 12:17:57 why not call the application and the directory "ac why not call the application and the directory "activity", matching what is in Flutter? I realize this is very Android-specific, but many of the services we have in services/ are to various degree tied with how Android APIs look like. I think we might want to stick to the convention of naming services by what they do not where they run for clarity. qsr 2015/11/24 13:05:05 Add comment about the fact that this application r Show quoted text On 2015/11/24 12:17:57, ppi wrote: > why not call the application and the directory "activity", matching what is in > Flutter? I realize this is very Android-specific, but many of the services we > have in services/ are to various degree tied with how Android APIs look like. I > think we might want to stick to the convention of naming services by what they > do not where they run for clarity. Add comment about the fact that this application regroups all android specific services.
9 java_files = [ "src/org/chromium/mojo/input/InputServiceImpl.java" ]	9 java_files = [ "src/org/chromium/mojo/android/ActivityImpl.java" ]

10	10

11 deps = [	11 deps = [

12 "//mojo/public/java:bindings",	12 "//mojo/public/java:bindings",

13 "//mojo/public/java:system",	13 "//mojo/public/java:system",

14 "//mojo/services/input/interfaces:interfaces_java",	14 "//mojo/services/android/interfaces:interfaces_java",

15 ]	15 ]

16 }	16 }

OLD	NEW