Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6507)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 14689007: Instant Extended: Move omnibox dropdown by 2 pixels (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
index 01821dbde4fab213a873faae0524ee25cd4fe245..08396807b0fd97ff9bc53ceaed3d1d8387e43331 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
@@ -260,10 +260,8 @@ willPositionSheet:(NSWindow*)sheet
} else {
// The tabContentArea view starts below the omnibox.
CGFloat minToolbarHeight = 0;
- if ([self hasToolbar]) {
- minToolbarHeight = [toolbarController_
- desiredHeightForCompression:bookmarks::kBookmarkBarOverlap];
- }
+ if ([self hasToolbar])
+ minToolbarHeight = [toolbarController_ desiredHeightForCompression:0] - 1;
Nico 2013/05/16 21:50:15 why -1?
sail 2013/05/16 22:09:58 This is for the toolbar separator. Added a comment
contentAreaTop = toolbarTopY - minToolbarHeight;
// This is the space between the bottom of the omnibox and the bottom of the
// last bar (info bar or bookmark bar or toolbar). This is used to push the

Powered by Google App Engine
This is Rietveld 408576698