Instant Extended: Move omnibox dropdown by 2 pixels

chrome/browser/ui/cocoa/browser_window_controller_private.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller_private.h"
 
 #include <cmath>
 
 #include "base/command_line.h"
 #import "base/memory/scoped_nsobject.h"
@@ skipping 242 matching lines @@
     contentAreaTop = maxY;
     CGFloat floatingBarHeight =
         NSHeight(floatingBarBackingRect) * [self floatingBarShownFraction];
     // When an instant overlay is shown this is the amount it needs to be pushed
     // down so that it doesn't get covered by the floating toolbar.
     toolbarToWebContentsOffset_ =
         floatingBarHeight - (NSMaxY(contentBounds) - maxY);
   } else {
     // The tabContentArea view starts below the omnibox.
     CGFloat minToolbarHeight = 0;
-    if ([self hasToolbar]) {
-      minToolbarHeight = [toolbarController_
-          desiredHeightForCompression:bookmarks::kBookmarkBarOverlap];
-    }
+    if ([self hasToolbar])
+      minToolbarHeight = [toolbarController_ desiredHeightForCompression:0] - 1;

[Nico, 2013/05/16 21:50:15]

why -1?

[sail, 2013/05/16 22:09:58]

This is for the toolbar separator. Added a comment explaining this.

     contentAreaTop = toolbarTopY - minToolbarHeight;
     // This is the space between the bottom of the omnibox and the bottom of the
     // last bar (info bar or bookmark bar or toolbar). This is used to push the
     // tab web content down when no instant overlay is shown.
     toolbarToWebContentsOffset_ = contentAreaTop - maxY;
   }
   [self updateContentOffsets];
 
   NSRect contentAreaRect = NSMakeRect(minX, minY, width, contentAreaTop - minY);
   [self layoutTabContentArea:contentAreaRect];
@@ skipping 713 matching lines @@
                          relativeTo:[bookmarkBarController_ view]];
     } else {
       [contentView cr_ensureSubview:floatingBarBackingView_
                        isPositioned:NSWindowBelow
                          relativeTo:[bookmarkBarController_ view]];
     }
   }
 }
 
 @end  // @implementation BrowserWindowController(Private)