third_party/WebKit/Source/modules/webgl/WebGLTexture.h - Issue 1468883002: Fix the crash of compressedTexImage3D for the WebGL2 conformance test page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLTexture.h

Issue 1468883002: Fix the crash of compressedTexImage3D for the WebGL2 conformance test page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add the check validation of level. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp ('K') | « third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLTexture.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLTexture.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLTexture.h b/third_party/WebKit/Source/modules/webgl/WebGLTexture.h

index c8c3524c6cf648666487d97a75940542cd691a88..84915380f8924a2a2dbd0a9b72dd2e5623ac1760 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLTexture.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLTexture.h

@@ -64,6 +64,7 @@ public:

GLsizei getHeight(GLenum target, GLint level) const;

GLsizei getDepth(GLenum target, GLint level) const;

bool isValid(GLenum target, GLint level) const;

+ bool isValidLevel(GLenum target, GLint level) const;

bool isImmutable() const { return m_immutable; }

static GLenum getValidFormatForInternalFormat(GLenum);