build/toolchain/win/BUILD.gn - Issue 1468643002: Tweaks to vs_toolchain to simplify it, and support gn VS 2015

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/win/BUILD.gn

Issue 1468643002: Tweaks to vs_toolchain to simplify it, and support gn VS 2015 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove default value for argument Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain/win/BUILD.gn

diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn

index e3100399575941eb81519f51096487f4f217ad78..777c6e9e01d7f0213551df68aacef29f73c1722f 100644

--- a/build/toolchain/win/BUILD.gn

+++ b/build/toolchain/win/BUILD.gn

@@ -26,8 +26,8 @@ if (use_goma) {

# This value will be inherited in the toolchain below.

concurrent_links = exec_script("../get_concurrent_links.py", [], "value")

-# Copy the VS runtime DLL for the default toolchain the root build directory so

-# things will run.

+# Copy the VS runtime DLL for the default toolchain to the root build directory

+# so things will run.

if (current_toolchain == default_toolchain) {

if (is_debug) {

configuration_name = "Debug"

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | build/vs_toolchain.py » ('j') | no next file with comments »