DevTools: Prettify websocket frames preview on Network pane.

DevTools: Prettify websocket frames preview on Network pane.

Add JSON style formatting.

BUG=488978
Committed: https://crrev.com/161006a2ac007e7b3f592049f82e8454367bc523
Cr-Commit-Position: refs/heads/master@{#361026}

[alph, 2015-11-20 22:11:02]

alph@chromium.org changed reviewers:
+ caseq@chromium.org, pfeldman@chromium.org

[alph, 2015-11-20 22:11:03]

ptal

[caseq, 2015-11-20 22:23:41]

lgtm

https://codereview.chromium.org/1468633002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
(right):

https://codereview.chromium.org/1468633002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:121:
var contentProvider = selectedNode.contentProvider();
nit: drop the var?

https://codereview.chromium.org/1468633002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:124:
* @this {WebInspector.ResourceWebSocketFrameView}
nit: @param, then @this?

https://codereview.chromium.org/1468633002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:129:
if (this._messageView)
s/this._messageView/this._currentView/ and nuke the this._dataView, then remove
conditional here.

[alph, 2015-11-20 22:38:46]

https://codereview.chromium.org/1468633002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
(right):

https://codereview.chromium.org/1468633002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:121:
var contentProvider = selectedNode.contentProvider();
On 2015/11/20 22:23:41, caseq wrote:
> nit: drop the var?

noway

https://codereview.chromium.org/1468633002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:124:
* @this {WebInspector.ResourceWebSocketFrameView}
On 2015/11/20 22:23:41, caseq wrote:
> nit: @param, then @this?

Done.

https://codereview.chromium.org/1468633002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js:129:
if (this._messageView)
On 2015/11/20 22:23:41, caseq wrote:
> s/this._messageView/this._currentView/ and nuke the this._dataView, then
remove
> conditional here.
I can go deeper.

[alph, 2015-11-20 23:08:48]

The CQ bit was checked by alph@chromium.org

[alph, 2015-11-20 23:08:48]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/1468633002/#ps20001
(title: "addressing comments.")

[commit-bot: I haz the power, 2015-11-20 23:10:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1468633002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1468633002/20001

[commit-bot: I haz the power, 2015-11-20 23:21:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-20 23:21:39]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[alph, 2015-11-20 23:38:45]

Pavel, could you please take a look.

[alph, 2015-11-21 01:08:47]

The CQ bit was checked by alph@chromium.org

[alph, 2015-11-21 01:08:47]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/1468633002/#ps40001
(title: "update tests.")

[commit-bot: I haz the power, 2015-11-21 01:09:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1468633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1468633002/40001

[commit-bot: I haz the power, 2015-11-21 03:27:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-21 03:27:54]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[alph, 2015-11-21 04:11:45]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2015-11-21 04:11:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1468633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1468633002/40001

[commit-bot: I haz the power, 2015-11-21 07:28:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-21 07:28:29]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[alph, 2015-11-21 16:21:10]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2015-11-21 16:21:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1468633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1468633002/40001

[commit-bot: I haz the power, 2015-11-21 17:24:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-21 17:24:47]

Patchset 3 (id:??) landed as
https://crrev.com/161006a2ac007e7b3f592049f82e8454367bc523
Cr-Commit-Position: refs/heads/master@{#361026}