Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

Issue 1468633002: DevTools: Prettify websocket frames preview on Network pane. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update tests. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js b/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
index 6a53142686bb9e6cb1305cfad2d5dc854bcda86e..36aa1aa589f280d3fd8462993cca9329509080c4 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js
@@ -49,8 +49,8 @@ WebInspector.ResourceWebSocketFrameView = function(request)
this._dataGrid.addEventListener(WebInspector.DataGrid.Events.SelectedNode, this._onFrameSelected, this);
this._splitWidget.setMainWidget(this._dataGrid.asWidget());
- this._messageView = new WebInspector.EmptyWidget("Select frame to browse its content.");
- this._splitWidget.setSidebarWidget(this._messageView);
+ var view = new WebInspector.EmptyWidget("Select frame to browse its content.");
+ this._splitWidget.setSidebarWidget(view);
}
/** @enum {number} */
@@ -116,12 +116,12 @@ WebInspector.ResourceWebSocketFrameView.prototype = {
_onFrameSelected: function(event)
{
var selectedNode = /** @type {!WebInspector.ResourceWebSocketFrameNode} */ (event.target.selectedNode);
- if (this._messageView)
- this._messageView.detach();
- if (this._dataView)
- this._dataView.detach();
- this._dataView = new WebInspector.ResourceSourceFrame(selectedNode.contentProvider());
- this._splitWidget.setSidebarWidget(this._dataView);
+ var contentProvider = selectedNode.contentProvider();
+ contentProvider.requestContent(content => {
+ var parsedJSON = content ? WebInspector.JSONView.parseJSON(content) : null;
+ var view = parsedJSON ? new WebInspector.JSONView(parsedJSON) : new WebInspector.ResourceSourceFrame(contentProvider);
+ this._splitWidget.setSidebarWidget(view);
+ });
},
refresh: function()

Powered by Google App Engine
This is Rietveld 408576698