Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 146863003: Revert "Turn NVPR on by default (but off in tools)." (Closed)

Created:
6 years, 11 months ago by mtklein
Modified:
6 years, 11 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert "Turn NVPR on by default (but off in tools)." This reverts commit 83d81c96de34950bdd84dc575997a250b685a3d6. Broke Windows build. Autorevert didn't work. TBR=bsalomon@google.com,robertphillips@google.com NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true BUG=skia:2042 Committed: https://code.google.com/p/skia/source/detail?r=13169

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -347 lines) Patch
A + expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Release-NVPR/expected-results.json View 114 chunks +114 lines, -157 lines 0 comments Download
M gyp/common_variables.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M gyp/gpu.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M include/gpu/GrContextFactory.h View 6 chunks +3 lines, -28 lines 0 comments Download
M include/gpu/gl/GrGLConfig.h View 2 chunks +8 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLExtensions.h View 2 chunks +2 lines, -12 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 3 chunks +2 lines, -7 lines 0 comments Download
M samplecode/SampleApp.cpp View 3 chunks +3 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLExtensions.cpp View 2 chunks +9 lines, -41 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 4 chunks +3 lines, -74 lines 0 comments Download
M src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/gl/win/SkNativeGLContext_win.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/GLInterfaceValidation.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/146863003/1
6 years, 11 months ago (2014-01-24 15:55:46 UTC) #1
commit-bot: I haz the power
Presubmit check for 146863003-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 11 months ago (2014-01-24 15:55:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/146863003/1
6 years, 11 months ago (2014-01-24 15:58:48 UTC) #3
commit-bot: I haz the power
Presubmit check for 146863003-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 11 months ago (2014-01-24 15:59:09 UTC) #4
hal.canary
6 years, 11 months ago (2014-01-24 16:04:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r13169.

Powered by Google App Engine
This is Rietveld 408576698