Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: components/scheduler/base/time_domain.cc

Issue 1468443002: Reduce the number of delayed tasks on chromium run loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Weak pointer Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/scheduler/base/time_domain.h ('k') | components/scheduler/base/time_domain_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/scheduler/base/time_domain.cc
diff --git a/components/scheduler/base/time_domain.cc b/components/scheduler/base/time_domain.cc
index 825812e43744907799923364dfc5c182a29548ec..2abfb522ce86f0d788285b03eb3127d4f1f56de9 100644
--- a/components/scheduler/base/time_domain.cc
+++ b/components/scheduler/base/time_domain.cc
@@ -12,7 +12,7 @@
namespace scheduler {
-TimeDomain::TimeDomain() : weak_factory_(this) {}
+TimeDomain::TimeDomain() {}
TimeDomain::~TimeDomain() {}
@@ -31,7 +31,7 @@ void TimeDomain::UnregisterQueue(internal::TaskQueueImpl* queue) {
}
}
- // |newly_updatable_| might contain |task_queue|, we use
+ // |newly_updatable_| might contain |queue|, we use
// MoveNewlyUpdatableQueuesIntoUpdatableQueueSet to flush it out.
MoveNewlyUpdatableQueuesIntoUpdatableQueueSet();
updatable_queue_set_.erase(queue);
@@ -66,12 +66,12 @@ void TimeDomain::ScheduleDelayedWork(internal::TaskQueueImpl* queue,
base::TimeTicks delayed_run_time,
LazyNow* lazy_now) {
DCHECK(main_thread_checker_.CalledOnValidThread());
- // Dedupe wakeups.
- if (delayed_wakeup_multimap_.find(delayed_run_time) ==
- delayed_wakeup_multimap_.end()) {
+
+ if (delayed_wakeup_multimap_.empty() ||
+ delayed_run_time < delayed_wakeup_multimap_.begin()->first) {
base::TimeDelta delay =
std::max(base::TimeDelta(), delayed_run_time - lazy_now->Now());
- RequestWakeup(delay);
+ RequestWakeup(lazy_now, delay);
}
delayed_wakeup_multimap_.insert(std::make_pair(delayed_run_time, queue));
}
« no previous file with comments | « components/scheduler/base/time_domain.h ('k') | components/scheduler/base/time_domain_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698