Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: components/scheduler/base/time_domain.cc

Issue 1468443002: Reduce the number of delayed tasks on chromium run loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Weak pointer Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/scheduler/base/time_domain.h" 5 #include "components/scheduler/base/time_domain.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "components/scheduler/base/task_queue_impl.h" 9 #include "components/scheduler/base/task_queue_impl.h"
10 #include "components/scheduler/base/task_queue_manager_delegate.h" 10 #include "components/scheduler/base/task_queue_manager_delegate.h"
11 #include "components/scheduler/scheduler_export.h" 11 #include "components/scheduler/scheduler_export.h"
12 12
13 namespace scheduler { 13 namespace scheduler {
14 14
15 TimeDomain::TimeDomain() : weak_factory_(this) {} 15 TimeDomain::TimeDomain() {}
16 16
17 TimeDomain::~TimeDomain() {} 17 TimeDomain::~TimeDomain() {}
18 18
19 void TimeDomain::UnregisterQueue(internal::TaskQueueImpl* queue) { 19 void TimeDomain::UnregisterQueue(internal::TaskQueueImpl* queue) {
20 // We need to remove |task_queue| from delayed_wakeup_multimap_ which is a 20 // We need to remove |task_queue| from delayed_wakeup_multimap_ which is a
21 // little awkward since it's keyed by time. O(n) running time. 21 // little awkward since it's keyed by time. O(n) running time.
22 for (DelayedWakeupMultimap::iterator iter = delayed_wakeup_multimap_.begin(); 22 for (DelayedWakeupMultimap::iterator iter = delayed_wakeup_multimap_.begin();
23 iter != delayed_wakeup_multimap_.end();) { 23 iter != delayed_wakeup_multimap_.end();) {
24 if (iter->second == queue) { 24 if (iter->second == queue) {
25 DelayedWakeupMultimap::iterator temp = iter; 25 DelayedWakeupMultimap::iterator temp = iter;
26 iter++; 26 iter++;
27 // O(1) amortized. 27 // O(1) amortized.
28 delayed_wakeup_multimap_.erase(temp); 28 delayed_wakeup_multimap_.erase(temp);
29 } else { 29 } else {
30 iter++; 30 iter++;
31 } 31 }
32 } 32 }
33 33
34 // |newly_updatable_| might contain |task_queue|, we use 34 // |newly_updatable_| might contain |queue|, we use
35 // MoveNewlyUpdatableQueuesIntoUpdatableQueueSet to flush it out. 35 // MoveNewlyUpdatableQueuesIntoUpdatableQueueSet to flush it out.
36 MoveNewlyUpdatableQueuesIntoUpdatableQueueSet(); 36 MoveNewlyUpdatableQueuesIntoUpdatableQueueSet();
37 updatable_queue_set_.erase(queue); 37 updatable_queue_set_.erase(queue);
38 } 38 }
39 39
40 void TimeDomain::MigrateQueue(internal::TaskQueueImpl* queue, 40 void TimeDomain::MigrateQueue(internal::TaskQueueImpl* queue,
41 TimeDomain* destination_time_domain) { 41 TimeDomain* destination_time_domain) {
42 LazyNow destination_lazy_now = destination_time_domain->CreateLazyNow(); 42 LazyNow destination_lazy_now = destination_time_domain->CreateLazyNow();
43 // We need to remove |task_queue| from delayed_wakeup_multimap_ which is a 43 // We need to remove |task_queue| from delayed_wakeup_multimap_ which is a
44 // little awkward since it's keyed by time. O(n) running time. 44 // little awkward since it's keyed by time. O(n) running time.
(...skipping 14 matching lines...) Expand all
59 // |newly_updatable_| might contain |queue|, we use 59 // |newly_updatable_| might contain |queue|, we use
60 // MoveNewlyUpdatableQueuesIntoUpdatableQueueSet to flush it out. 60 // MoveNewlyUpdatableQueuesIntoUpdatableQueueSet to flush it out.
61 MoveNewlyUpdatableQueuesIntoUpdatableQueueSet(); 61 MoveNewlyUpdatableQueuesIntoUpdatableQueueSet();
62 updatable_queue_set_.erase(queue); 62 updatable_queue_set_.erase(queue);
63 } 63 }
64 64
65 void TimeDomain::ScheduleDelayedWork(internal::TaskQueueImpl* queue, 65 void TimeDomain::ScheduleDelayedWork(internal::TaskQueueImpl* queue,
66 base::TimeTicks delayed_run_time, 66 base::TimeTicks delayed_run_time,
67 LazyNow* lazy_now) { 67 LazyNow* lazy_now) {
68 DCHECK(main_thread_checker_.CalledOnValidThread()); 68 DCHECK(main_thread_checker_.CalledOnValidThread());
69 // Dedupe wakeups. 69
70 if (delayed_wakeup_multimap_.find(delayed_run_time) == 70 if (delayed_wakeup_multimap_.empty() ||
71 delayed_wakeup_multimap_.end()) { 71 delayed_run_time < delayed_wakeup_multimap_.begin()->first) {
72 base::TimeDelta delay = 72 base::TimeDelta delay =
73 std::max(base::TimeDelta(), delayed_run_time - lazy_now->Now()); 73 std::max(base::TimeDelta(), delayed_run_time - lazy_now->Now());
74 RequestWakeup(delay); 74 RequestWakeup(lazy_now, delay);
75 } 75 }
76 delayed_wakeup_multimap_.insert(std::make_pair(delayed_run_time, queue)); 76 delayed_wakeup_multimap_.insert(std::make_pair(delayed_run_time, queue));
77 } 77 }
78 78
79 void TimeDomain::RegisterAsUpdatableTaskQueue(internal::TaskQueueImpl* queue) { 79 void TimeDomain::RegisterAsUpdatableTaskQueue(internal::TaskQueueImpl* queue) {
80 base::AutoLock lock(newly_updatable_lock_); 80 base::AutoLock lock(newly_updatable_lock_);
81 newly_updatable_.push_back(queue); 81 newly_updatable_.push_back(queue);
82 } 82 }
83 83
84 void TimeDomain::UnregisterAsUpdatableTaskQueue( 84 void TimeDomain::UnregisterAsUpdatableTaskQueue(
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 state->SetString("name", GetName()); 169 state->SetString("name", GetName());
170 state->BeginArray("updatable_queue_set"); 170 state->BeginArray("updatable_queue_set");
171 for (auto& queue : updatable_queue_set_) 171 for (auto& queue : updatable_queue_set_)
172 state->AppendString(queue->GetName()); 172 state->AppendString(queue->GetName());
173 state->EndArray(); 173 state->EndArray();
174 AsValueIntoInternal(state); 174 AsValueIntoInternal(state);
175 state->EndDictionary(); 175 state->EndDictionary();
176 } 176 }
177 177
178 } // namespace scheduler 178 } // namespace scheduler
OLDNEW
« no previous file with comments | « components/scheduler/base/time_domain.h ('k') | components/scheduler/base/time_domain_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698