Issue 1468433002: VM: Fix optimizer bug in smi-op widening.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1468433002: VM: Fix optimizer bug in smi-op widening. (Closed)

Created:
5 years, 1 month ago by Florian Schneider

Modified:
5 years, 1 month ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Fix optimizer bug in smi-op widening. Only consider operations that are used (have an SSA temp) for widening. Operations without uses will be eliminated as dead code anyway later. BUG=dartbug.com/24987 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/166b3ddfe3d974e25a04ca576bf40d2b0a0bdb42

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

5 years, 1 month ago (2015-11-23 08:47:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
166b3ddfe3d974e25a04ca576bf40d2b0a0bdb42 (presubmit successful).