runtime/vm/flow_graph_optimizer.cc - Issue 1468433002: VM: Fix optimizer bug in smi-op widening.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 1468433002: VM: Fix optimizer bug in smi-op widening. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_optimizer.cc

diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc

index a22dc50841bb8b426f654ef6c24484bb974311c9..22ba02f3634f57a2e3e94b7bd309edfa4f08b701 100644

--- a/runtime/vm/flow_graph_optimizer.cc

+++ b/runtime/vm/flow_graph_optimizer.cc

@@ -4836,6 +4836,7 @@ void FlowGraphOptimizer::WidenSmiToInt32() {

instr_it.Advance()) {

BinarySmiOpInstr* smi_op = instr_it.Current()->AsBinarySmiOp();

if ((smi_op != NULL) &&

+ smi_op->HasSSATemp() &&

BenefitsFromWidening(smi_op) &&

CanBeWidened(smi_op)) {

candidates.Add(smi_op);

« no previous file with comments | « no previous file | no next file » | no next file with comments »