Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1468373002: [proxies] Use internalized strings for trap names. (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Use internalized strings for trap names. R=rossberg BUG= Committed: https://crrev.com/e3c1cd84a41cbfb2c7ddeb3c16981cc0654ac4ea Cr-Commit-Position: refs/heads/master@{#32196}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M src/bootstrapper.cc View 2 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
neis
5 years ago (2015-11-24 09:03:43 UTC) #1
rossberg
lgtm
5 years ago (2015-11-24 09:26:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468373002/1
5 years ago (2015-11-24 09:28:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 09:44:46 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-24 09:45:05 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3c1cd84a41cbfb2c7ddeb3c16981cc0654ac4ea
Cr-Commit-Position: refs/heads/master@{#32196}

Powered by Google App Engine
This is Rietveld 408576698