Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Unified Diff: src/bootstrapper.cc

Issue 1468373002: [proxies] Use internalized strings for trap names. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index 3db75a4dc048af5118017137ca510dbfdfdbe3ca..afc25508e62bdd4b6fd6291409e38608a8687d12 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -2065,11 +2065,11 @@ EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_do_expressions)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_regexp_lookbehind)
-static void SimpleInstallFunction(Handle<JSObject>& base, const char* name,
+static void SimpleInstallFunction(Handle<JSObject> base, Handle<Name> name,
Builtins::Name call, int len, bool adapt) {
Handle<JSFunction> fun =
InstallFunction(base, name, JS_OBJECT_TYPE, JSObject::kHeaderSize,
- MaybeHandle<JSObject>(), call);
+ MaybeHandle<JSObject>(), call, DONT_ENUM);
if (adapt) {
fun->shared()->set_internal_formal_parameter_count(len);
} else {
@@ -2123,35 +2123,35 @@ void Genesis::InitializeGlobal_harmony_regexp_subclass() {
void Genesis::InitializeGlobal_harmony_reflect() {
if (!FLAG_harmony_reflect) return;
+ Factory* factory = isolate()->factory();
Handle<JSGlobalObject> global(JSGlobalObject::cast(
native_context()->global_object()));
- Handle<String> reflect_string =
- factory()->NewStringFromStaticChars("Reflect");
+ Handle<String> reflect_string = factory->NewStringFromStaticChars("Reflect");
Handle<JSObject> reflect =
- factory()->NewJSObject(isolate()->object_function(), TENURED);
+ factory->NewJSObject(isolate()->object_function(), TENURED);
JSObject::AddProperty(global, reflect_string, reflect, DONT_ENUM);
- SimpleInstallFunction(reflect, "defineProperty",
+ SimpleInstallFunction(reflect, factory->defineProperty_string(),
Builtins::kReflectDefineProperty, 3, true);
- SimpleInstallFunction(reflect, "deleteProperty",
+ SimpleInstallFunction(reflect, factory->deleteProperty_string(),
Builtins::kReflectDeleteProperty, 2, true);
- SimpleInstallFunction(reflect, "get",
+ SimpleInstallFunction(reflect, factory->get_string(),
Builtins::kReflectGet, 3, false);
- SimpleInstallFunction(reflect, "getOwnPropertyDescriptor",
+ SimpleInstallFunction(reflect, factory->getOwnPropertyDescriptor_string(),
Builtins::kReflectGetOwnPropertyDescriptor, 2, true);
- SimpleInstallFunction(reflect, "getPrototypeOf",
+ SimpleInstallFunction(reflect, factory->getPrototypeOf_string(),
Builtins::kReflectGetPrototypeOf, 1, true);
- SimpleInstallFunction(reflect, "has",
+ SimpleInstallFunction(reflect, factory->has_string(),
Builtins::kReflectHas, 2, true);
- SimpleInstallFunction(reflect, "isExtensible",
+ SimpleInstallFunction(reflect, factory->isExtensible_string(),
Builtins::kReflectIsExtensible, 1, true);
- SimpleInstallFunction(reflect, "ownKeys",
+ SimpleInstallFunction(reflect, factory->ownKeys_string(),
Builtins::kReflectOwnKeys, 1, true);
- SimpleInstallFunction(reflect, "preventExtensions",
+ SimpleInstallFunction(reflect, factory->preventExtensions_string(),
Builtins::kReflectPreventExtensions, 1, true);
- SimpleInstallFunction(reflect, "set",
+ SimpleInstallFunction(reflect, factory->set_string(),
Builtins::kReflectSet, 3, false);
- SimpleInstallFunction(reflect, "setPrototypeOf",
+ SimpleInstallFunction(reflect, factory->setPrototypeOf_string(),
Builtins::kReflectSetPrototypeOf, 2, true);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698