Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 146833017: android: disable NLS when building yasm. (Closed)

Created:
6 years, 10 months ago by Torne
Modified:
6 years, 10 months ago
CC:
chromium-reviews, irogers
Visibility:
Public.

Description

android: disable NLS when building yasm. When crosscompiling for android on mac hosts, some machines don't have the NLS header files available. Rather than insist on another build dependency, just disable NLS when building yasm; we can live without localisation in a build-time tool. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/yasm/README.chromium View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/yasm/source/config/android/config.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Torne
Is this okay with you Alpha? We need to support Mac host builds for android ...
6 years, 10 months ago (2014-01-28 16:00:19 UTC) #1
Torne
Just a quick ping now your calendar suggests you are back in the office ;)
6 years, 10 months ago (2014-02-12 11:48:15 UTC) #2
irogers
lgtm
6 years, 10 months ago (2014-02-12 16:46:18 UTC) #3
Torne
On 2014/02/12 16:46:18, irogers wrote: > lgtm unfortunately you don't count as we no longer ...
6 years, 10 months ago (2014-02-12 17:20:29 UTC) #4
Alpha Left Google
LGTM.
6 years, 10 months ago (2014-02-13 19:36:41 UTC) #5
Torne
The CQ bit was checked by torne@chromium.org
6 years, 10 months ago (2014-02-14 10:38:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/146833017/1
6 years, 10 months ago (2014-02-14 10:38:34 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 15:28:39 UTC) #8
Message was sent while issue was closed.
Change committed as 251333

Powered by Google App Engine
This is Rietveld 408576698