Issue 146833015: drive: FileCache::Store marks the entry as dirty if empty MD5 is given

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 146833015: drive: FileCache::Store marks the entry as dirty if empty MD5 is given (Closed)

Created:
6 years, 10 months ago by hashimoto

Modified:
6 years, 10 months ago

Reviewers:
kinaba

CC:
chromium-reviews, tim+watch_chromium.org, nkostylev+watch_chromium.org, tzik, tfarina, haitaol+watch_chromium.org, nhiroki, oshima+watch_chromium.org, kinuko+watch, rsimha+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: FileCache::Store marks the entry as dirty if empty MD5 is given Store() and MarkAsDirty() should be performed together, atomically. Otherwise, it may cause troubles when something goes wrong. (e.g. sudden shutdown of the device) Provide a way to perform Store() and MarkAsDirty() at the same time by specially handling empty MD5. BUG=260539 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247559

Patch Set 1 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -62 lines)			Patch
M	chrome/browser/chromeos/drive/file_cache.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/file_cache_unittest.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/copy_operation.cc	View	2 chunks	+2 lines, -13 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/download_operation.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/download_operation_unittest.cc	View	2 chunks	+1 line, -13 lines	0 comments	Download
M	chrome/browser/chromeos/drive/remove_stale_cache_files_unittest.cc	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc	View	1 chunk	+1 line, -16 lines	0 comments	Download
M	chrome/browser/chromeos/drive/sync_client_unittest.cc	View	2 chunks	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/146833015/20001

6 years, 10 months ago (2014-01-28 18:26:55 UTC) #3

Message was sent while issue was closed.

Change committed as 247559

Expand Messages | Collapse Messages