chrome/browser/chromeos/drive/file_system/copy_operation.cc - Issue 146833015: drive: FileCache::Store marks the entry as dirty if empty MD5 is given

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/file_system/copy_operation.cc

Issue 146833015: drive: FileCache::Store marks the entry as dirty if empty MD5 is given (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/drive/file_cache_unittest.cc ('k') | chrome/browser/chromeos/drive/file_system/download_operation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/drive/file_system/copy_operation.cc

diff --git a/chrome/browser/chromeos/drive/file_system/copy_operation.cc b/chrome/browser/chromeos/drive/file_system/copy_operation.cc

index d438095561bf56bb3ba006d5a2d0f1df3e824d70..6d987af1c4091ee7c9ea53f875364e511757e05f 100644

--- a/chrome/browser/chromeos/drive/file_system/copy_operation.cc

+++ b/chrome/browser/chromeos/drive/file_system/copy_operation.cc

@@ -6,7 +6,6 @@

#include <string>

-#include "base/callback_helpers.h"

#include "base/file_util.h"

#include "base/task_runner_util.h"

#include "chrome/browser/chromeos/drive/drive.pb.h"

@@ -110,18 +109,8 @@ FileError UpdateLocalStateForScheduleTransfer(

if (error != FILE_ERROR_OK)

return error;

- error = cache->Store(

- *local_id, entry.file_specific_info().md5(), local_src_path,

- internal::FileCache::FILE_OPERATION_COPY);

- if (error != FILE_ERROR_OK)

- return error;

- scoped_ptr<base::ScopedClosureRunner> file_closer;

- error = cache->OpenForWrite(*local_id, &file_closer);

- if (error != FILE_ERROR_OK)

- return error;

- return FILE_ERROR_OK;

+ return cache->Store(*local_id, std::string(), local_src_path,

+ internal::FileCache::FILE_OPERATION_COPY);

}

// Gets the file size of the |local_path|, and the ResourceEntry for the parent