Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: src/a64/code-stubs-a64.cc

Issue 146833011: A64: Don't use a 'debug' instruction to implement the 'trace_sim' option. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/a64/simulator-a64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2891 matching lines...) Expand 10 before | Expand all | Expand 10 after
2902 // x1: function. 2902 // x1: function.
2903 // x2: receiver. 2903 // x2: receiver.
2904 // x3: argc. 2904 // x3: argc.
2905 // x4: argv. 2905 // x4: argv.
2906 // Output: 2906 // Output:
2907 // x0: result. 2907 // x0: result.
2908 void JSEntryStub::GenerateBody(MacroAssembler* masm, bool is_construct) { 2908 void JSEntryStub::GenerateBody(MacroAssembler* masm, bool is_construct) {
2909 ASSERT(jssp.Is(__ StackPointer())); 2909 ASSERT(jssp.Is(__ StackPointer()));
2910 Register code_entry = x0; 2910 Register code_entry = x0;
2911 2911
2912 // TODO(all): We shouldn't emit debug instructions unconditionally since they
2913 // will not work outside the simulator. We need to rethink how these commands
2914 // interact with --trace-sim. For now, though, this turns on instruction
2915 // tracing _if_ --trace-sim is specified.
2916 __ Debug("TRACE ENTRY", 0, TRACE_ENABLE | LOG_ALL);
2917
2918 // Enable instruction instrumentation. This only works on the simulator, and 2912 // Enable instruction instrumentation. This only works on the simulator, and
2919 // will have no effect on the model or real hardware. 2913 // will have no effect on the model or real hardware.
2920 __ EnableInstrumentation(); 2914 __ EnableInstrumentation();
2921 2915
2922 Label invoke, handler_entry, exit; 2916 Label invoke, handler_entry, exit;
2923 2917
2924 // Push callee-saved registers and synchronize the system stack pointer (csp) 2918 // Push callee-saved registers and synchronize the system stack pointer (csp)
2925 // and the JavaScript stack pointer (jssp). 2919 // and the JavaScript stack pointer (jssp).
2926 // 2920 //
2927 // We must not write to jssp until after the PushCalleeSavedRegisters() 2921 // We must not write to jssp until after the PushCalleeSavedRegisters()
(...skipping 4330 matching lines...) Expand 10 before | Expand all | Expand 10 after
7258 __ Bind(&fast_elements_case); 7252 __ Bind(&fast_elements_case);
7259 GenerateCase(masm, FAST_ELEMENTS); 7253 GenerateCase(masm, FAST_ELEMENTS);
7260 } 7254 }
7261 7255
7262 7256
7263 #undef __ 7257 #undef __
7264 7258
7265 } } // namespace v8::internal 7259 } } // namespace v8::internal
7266 7260
7267 #endif // V8_TARGET_ARCH_A64 7261 #endif // V8_TARGET_ARCH_A64
OLDNEW
« no previous file with comments | « no previous file | src/a64/simulator-a64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698