ASan/Android: crash on calloc overflow.

ASan/Android: crash on calloc overflow.

This is the generally preferred behaviour that is also expected by the
unit tests.

BUG=325685
R=glider@chromium.org, navabi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247219

[Alexander Potapenko, 2014-01-27 11:21:34]

LGTM, but I'd prefer a comment describing why you're using this set of options.

On Mon, Jan 27, 2014 at 3:05 PM,  <eugenis@chromium.org> wrote:
> Reviewers: Alexander Potapenko, navabi1,
>
> Description:
> ASan/Android: crash on calloc overflow.
>
> This is the generally preferred behaviour that is also expected by the
> unit tests.
>
> BUG=325685
> R=glider@chromium.org, navabi@chromium.org
>
> Please review this at https://codereview.chromium.org/146833010/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+1, -1 lines):
>   M build/android/pylib/valgrind_tools.py
>
>
> Index: build/android/pylib/valgrind_tools.py
> diff --git a/build/android/pylib/valgrind_tools.py
> b/build/android/pylib/valgrind_tools.py
> index
>
0eb0d7b6175dd159f5d74a21969ffd068d9659b1..1a58897613c7c6b720dd29ac888f3ae6463aba52
> 100644
> --- a/build/android/pylib/valgrind_tools.py
> +++ b/build/android/pylib/valgrind_tools.py
> @@ -87,7 +87,7 @@ class AddressSanitizerTool(BaseTool):
>    """AddressSanitizer tool."""
>
>    WRAPPER_NAME = '/system/bin/asanwrapper'
> -  EXTRA_OPTIONS = 'allocator_may_return_null=1,strict_memcmp=0'
> +  EXTRA_OPTIONS = 'strict_memcmp=0'
>
>    def __init__(self, adb):
>      self._adb = adb
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[eugenis, 2014-01-27 11:23:28]

added a comment about the single remaining option

[eugenis, 2014-01-27 11:24:28]

Committed patchset #2 manually as r247219 (presubmit successful).