build/android/pylib/valgrind_tools.py - Issue 146833010: ASan/Android: crash on calloc overflow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/valgrind_tools.py

Issue 146833010: ASan/Android: crash on calloc overflow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/valgrind_tools.py

diff --git a/build/android/pylib/valgrind_tools.py b/build/android/pylib/valgrind_tools.py

index 0eb0d7b6175dd159f5d74a21969ffd068d9659b1..95ae2b9797a058052ab67dd9b836a25fbe400579 100644

--- a/build/android/pylib/valgrind_tools.py

+++ b/build/android/pylib/valgrind_tools.py

@@ -87,7 +87,10 @@ class AddressSanitizerTool(BaseTool):

"""AddressSanitizer tool."""

WRAPPER_NAME = '/system/bin/asanwrapper'

- EXTRA_OPTIONS = 'allocator_may_return_null=1,strict_memcmp=0'

+ # Disable memcmp overlap check.There are blobs (gl drivers)

+ # on some android devices that use memcmp on overlapping regions,

+ # nothing we can do about that.

+ EXTRA_OPTIONS = 'strict_memcmp=0'

def __init__(self, adb):

self._adb = adb

« no previous file with comments | « no previous file | no next file » | no next file with comments »