Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1468313009: Revert of [machine-operator-reducer] fix float truncation (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
titzer, fedor.indutny
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [machine-operator-reducer] fix float truncation (patchset #8 id:140001 of https://codereview.chromium.org/1433353006/ ) Reason for revert: This is also unsound for the reasons outlined in https://codereview.chromium.org/1473073004/ Will reland the mjsunit test separately and help Fedor to implement a solution based on simplified operators. Original issue's description: > [machine-operator-reducer] fix float truncation > > Don't replace `TruncateFloat64ToInt32(RoundInt64ToFloat64(value))` with > `value`. Generally, `value` may have a range bigger than the one that > could fit into Int32. Replace it with `TruncateInt64ToInt32(value)` > instead, and only if the `value` fits into Float64 without precision > loss. > > Add missing mjsunit test for 52bit multiplication/division optimization > that has landed in refs/heads/master@{#31899}. > > BUG= > R=titzer@google.com > > Committed: https://crrev.com/64efa2a904773816968992628f0bf0f1b7ae82be > Cr-Commit-Position: refs/heads/master@{#32227} TBR=titzer@chromium.org,fedor@indutny.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/dc554059927c68e852e75d818be34ee14067494f Cr-Commit-Position: refs/heads/master@{#32312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -120 lines) Patch
M src/compiler/machine-operator-reducer.cc View 1 chunk +1 line, -12 lines 0 comments Download
D test/mjsunit/math-52-mul-div.js View 1 chunk +0 lines, -86 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +1 line, -22 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Benedikt Meurer
Created Revert of [machine-operator-reducer] fix float truncation
5 years ago (2015-11-26 06:11:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1468313009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1468313009/1
5 years ago (2015-11-26 06:11:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 06:11:56 UTC) #4
commit-bot: I haz the power
5 years ago (2015-11-26 06:12:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc554059927c68e852e75d818be34ee14067494f
Cr-Commit-Position: refs/heads/master@{#32312}

Powered by Google App Engine
This is Rietveld 408576698