Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: src/compiler/machine-operator-reducer.cc

Issue 1468313009: Revert of [machine-operator-reducer] fix float truncation (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/math-52-mul-div.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/machine-operator-reducer.cc
diff --git a/src/compiler/machine-operator-reducer.cc b/src/compiler/machine-operator-reducer.cc
index 04af8d4a431a9ca9c9e875a05380359084192d03..5951fb612a9f75feb3f456f840a8c2d364cb80a2 100644
--- a/src/compiler/machine-operator-reducer.cc
+++ b/src/compiler/machine-operator-reducer.cc
@@ -648,18 +648,7 @@
Float64Matcher m(node->InputAt(0));
if (m.HasValue()) return ReplaceInt32(DoubleToInt32(m.Value()));
if (m.IsChangeInt32ToFloat64()) return Replace(m.node()->InputAt(0));
- if (m.IsRoundInt64ToFloat64()) {
- Node* value = m.node()->InputAt(0);
- Type* type = NodeProperties::GetType(value);
- Type::RangeType* range = type->GetRange();
-
- // Rounding int64 to float64 should not lose precision
- if (range != nullptr && range->Min() >= 0 &&
- range->Max() <= 0xFFFFFFFFFFFFFULL) {
- return Replace(
- graph()->NewNode(machine()->TruncateInt64ToInt32(), value));
- }
- }
+ if (m.IsRoundInt64ToFloat64()) return Replace(m.node()->InputAt(0));
if (m.IsPhi()) {
Node* const phi = m.node();
DCHECK_EQ(kRepFloat64, RepresentationOf(OpParameter<MachineType>(phi)));
« no previous file with comments | « no previous file | test/mjsunit/math-52-mul-div.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698