Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(907)

Issue 1468273003: Revert of Use sysroot by default for all linux builds (Closed)

Created:
5 years, 1 month ago by Steven Holte
Modified:
5 years, 1 month ago
CC:
chromium-reviews, brettw, Lei Zhang, mnaganov (inactive)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use sysroot by default for all linux builds (patchset #7 id:120001 of https://codereview.chromium.org/1464983003/ ) Reason for revert: https://crbug.com/560603 Suspect this breaks webview_licenses Original issue's description: > Use sysroot by default for all linux builds > > Using a sysroot was already the default for official > build and when cross compiling (e.g. arm, mips, x86-32). > This change makes it the default in all cases. > > The old behavior of building against local > system libraries can still be achieved by > setting use_sysroot=0 > > BUG=504446 > > Committed: https://crrev.com/a931efd5dc8d8783ce73a64fc641627866b6869d > Cr-Commit-Position: refs/heads/master@{#361197} TBR=dpranke@chromium.org,thestig@chromium.org,thakis@chromium.org,sbc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -22 lines) Patch
M build/common.gypi View 2 chunks +6 lines, -10 lines 0 comments Download
M build/config/sysroot.gni View 2 chunks +12 lines, -8 lines 0 comments Download
M build/linux/sysroot_scripts/install-sysroot.py View 3 chunks +26 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Steven Holte
Created Revert of Use sysroot by default for all linux builds
5 years, 1 month ago (2015-11-24 01:45:39 UTC) #1
Lei Zhang
5 years, 1 month ago (2015-11-24 01:56:55 UTC) #2
https://codereview.chromium.org/1473533003 will fix the issue instead?

Powered by Google App Engine
This is Rietveld 408576698